-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (storage) fix failing testcase #12590
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 109 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@@ -824,7 +824,7 @@ func TestAccStorageBucket_update(t *testing.T) { | |||
Check: resource.ComposeTestCheckFunc( | |||
testAccCheckStorageBucketExists( | |||
t, "google_storage_bucket.bucket", bucketName, &recreated), | |||
testAccCheckStorageBucketWasRecreated(&recreated, &bucket), | |||
testAccCheckStorageBucketWasUpdated(&recreated, &bucket), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a lot of bucket update tests. Even the next test step will check that only so what is the need of this step?
If we don't want to test ForceNew behavior then we can completely remove this step otherwise if we somehow need to check recreation of bucket, we can add step with different bucket name and that will force recreation of bucket. I am not sure if that will help here reducing flaky test failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the first step
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 109 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
create and update the bucket in same region
Fixes: hashicorp/terraform-provider-google#20577
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.