Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamecontribute #12583

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

nityaravi
Copy link
Contributor

@nityaravi nityaravi commented Dec 16, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@nityaravi nityaravi requested a review from melinath December 16, 2024 18:41
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you resolve the merge conflict?

@nityaravi
Copy link
Contributor Author

could you resolve the merge conflict?

Done

@github-actions github-actions bot requested a review from melinath December 16, 2024 19:50
docs/content/reference/field.md Outdated Show resolved Hide resolved
docs/content/reference/resource.md Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from melinath December 16, 2024 19:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath melinath merged commit 483e328 into GoogleCloudPlatform:main Dec 16, 2024
8 of 9 checks passed
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

cesteve pushed a commit to cesteve/magic-modules that referenced this pull request Dec 17, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants