Fix ApigeeOrganization update response type.

[masich]

Fixes hashicorp/terraform-provider-google#15947.

This PR fixes the ApigeeOrganization update response type according to the public documentation.

The issue is related to the fact that after requesting the update to ApigeeOrganization here, the provider expects that the response will contain the Operation details to then wait for the Operation to complete here. Unlike Organization create request, which returns Operation, the update response is an Organization instance according to the public docs, meaning that the ApigeeOperationWaitTime tries to process the Organization as Operation.

The Operation has a name key that is used to track its progress. However, the Organization also has a name key, that contains the name of the Organization. That's why the users see a weird apigee.googleapis.com/v1/<org-name>?alt=json GET request in a linked GitHub issue. In that case, the ApigeeOperationWaitTime interprets <org-name> as the operation name.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

apigee: fixed error 404 for `organization` update requests.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 8 deletions(-))

[modular-magician]

Tests analytics

Total tests: 51
Passed tests: 16
Skipped tests: 34
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[masich]

It looks like the failed TestAccApigeeDeveloper_apigeeDeveloperUpdateTest test is flaky and has an entirely unrelated error. Also, it passed for my other PRs and in my local env:

--- PASS: TestAccApigeeDeveloper_apigeeDeveloperUpdateTest (2607.87s)

[roaks3]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 8 deletions(-))

[modular-magician]

Tests analytics

Total tests: 51
Passed tests: 16
Skipped tests: 34
Affected tests: 1

Click here to see the affected service packages

• apigee

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccApigeeDeveloper_apigeeDeveloperUpdateTest

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

🟢 All tests passed!

View the build log or the debug log for each test

[github-actions]

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

Nice find! Code and solution LGTM, but it would be great to have a test for this if possible. Specifically, I don't think that any existing tests try to update an Apigee Organization, which would have alerted us to this issue sooner (ideally during review). You would be adding an update test (assuming this is feasible).

[github-actions]

@masich, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.