-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dcl to 1.76.0 #12392
Upgrade dcl to 1.76.0 #12392
Conversation
10d7e7e
to
409b39c
Compare
409b39c
to
08b66af
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloudbuild_worker_pool" "primary" {
private_service_connect {
network_attachment = # value needed
route_all_traffic = # value needed
}
}
Resource: resource "google_clouddeploy_delivery_pipeline" "primary" {
serial_pipeline {
stages {
strategy {
canary {
runtime_config {
kubernetes {
gateway_service_mesh {
route_destinations {
destination_ids = # value needed
propagate_service = # value needed
}
}
}
}
}
}
}
}
}
Resource: resource "google_clouddeploy_target" "primary" {
associated_entities {
anthos_clusters {
membership = # value needed
}
entity_name = # value needed
gke_clusters {
cluster = # value needed
internal_ip = # value needed
proxy_url = # value needed
}
}
}
Resource: resource "google_gke_hub_feature_membership" "primary" {
configmanagement {
config_sync {
metrics_gcp_service_account_email = # value needed
stop_syncing = # value needed
}
}
}
|
Tests analyticsTotal tests: 4303 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_clouddeploy_target" "primary" {
associated_entities {
entity_name = # value needed
gke_clusters {
internal_ip = # value needed
proxy_url = # value needed
}
}
}
Resource: resource "google_gke_hub_feature_membership" "primary" {
configmanagement {
config_sync {
metrics_gcp_service_account_email = # value needed
stop_syncing = # value needed
}
}
}
|
6bd96f5
to
19094d7
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_clouddeploy_target" "primary" {
associated_entities {
entity_name = # value needed
gke_clusters {
internal_ip = # value needed
proxy_url = # value needed
}
}
}
Resource: resource "google_gke_hub_feature_membership" "primary" {
configmanagement {
config_sync {
metrics_gcp_service_account_email = # value needed
}
}
}
|
Tests analyticsTotal tests: 4307 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 4307 Click here to see the affected service packages
Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
19094d7
to
d7e1f4c
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_feature_membership" "primary" {
configmanagement {
config_sync {
metrics_gcp_service_account_email = # value needed
}
}
}
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Tests analyticsTotal tests: 4306 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gke_hub_feature_membership" "primary" {
configmanagement {
config_sync {
metrics_gcp_service_account_email = # value needed
}
}
}
|
Tests analyticsTotal tests: 4308 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
@zli82016 , please remove the extra space: |
The failed test |
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
This field was added to `google_gke_hub_feature_membership` resource in DCL 1.76.0: GoogleCloudPlatform#12392.
This field was added to `google_gke_hub_feature_membership` resource in DCL 1.76.0: GoogleCloudPlatform#12392.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.