Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dcl to 1.76.0 #12392

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Nov 21, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

cloudbuild: added `private_service_connect` field to `google_cloudbuild_worker_pool` resource
clouddeploy: added `associated_entities` field to `google_clouddeploy_target` resource
clouddeploy: added `serial_pipeline.strategy.canary.runtime_config.kubernetes.gateway_service_mesh.route_destinations` field to `google_clouddeploy_delivery_pipeline` resource
gkehub: added `configmanagement.config_sync.stop_syncing` field to `google_gke_hub_feature_membership` resource
gkehub: deprecated `configmanagement.config_sync.metrics_gcp_service_account_email` in `google_gke_hub_feature_membership` resource

@zli82016 zli82016 force-pushed the dcl-v1.76.0 branch 2 times, most recently from 10d7e7e to 409b39c Compare November 21, 2024 22:15
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 537 insertions(+), 96 deletions(-))
google-beta provider: Diff ( 10 files changed, 537 insertions(+), 96 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloudbuild_worker_pool (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloudbuild_worker_pool" "primary" {
  private_service_connect {
    network_attachment = # value needed
    route_all_traffic  = # value needed
  }
}

Resource: google_clouddeploy_delivery_pipeline (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_delivery_pipeline" "primary" {
  serial_pipeline {
    stages {
      strategy {
        canary {
          runtime_config {
            kubernetes {
              gateway_service_mesh {
                route_destinations {
                  destination_ids   = # value needed
                  propagate_service = # value needed
                }
              }
            }
          }
        }
      }
    }
  }
}

Resource: google_clouddeploy_target (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_target" "primary" {
  associated_entities {
    anthos_clusters {
      membership = # value needed
    }
    entity_name = # value needed
    gke_clusters {
      cluster     = # value needed
      internal_ip = # value needed
      proxy_url   = # value needed
    }
  }
}

Resource: google_gke_hub_feature_membership (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  configmanagement {
    config_sync {
      metrics_gcp_service_account_email = # value needed
      stop_syncing                      = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4303
Passed tests: 3895
Skipped tests: 406
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 566 insertions(+), 101 deletions(-))
google-beta provider: Diff ( 14 files changed, 571 insertions(+), 101 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_target (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_target" "primary" {
  associated_entities {
    entity_name = # value needed
    gke_clusters {
      internal_ip = # value needed
      proxy_url   = # value needed
    }
  }
}

Resource: google_gke_hub_feature_membership (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  configmanagement {
    config_sync {
      metrics_gcp_service_account_email = # value needed
      stop_syncing                      = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 566 insertions(+), 101 deletions(-))
google-beta provider: Diff ( 14 files changed, 571 insertions(+), 101 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_clouddeploy_target (27 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_clouddeploy_target" "primary" {
  associated_entities {
    entity_name = # value needed
    gke_clusters {
      internal_ip = # value needed
      proxy_url   = # value needed
    }
  }
}

Resource: google_gke_hub_feature_membership (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  configmanagement {
    config_sync {
      metrics_gcp_service_account_email = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4307
Passed tests: 3894
Skipped tests: 407
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccCloudbuildWorkerPool_withNetwork
  • TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline
  • TestAccClouddeployTarget_Target
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_withNetwork [Error message] [Debug log]
TestAccClouddeployTarget_Target [Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4307
Passed tests: 3894
Skipped tests: 407
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccCloudbuildWorkerPool_withNetwork
  • TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline
  • TestAccClouddeployTarget_Target
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 566 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 14 files changed, 571 insertions(+), 98 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature_membership (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  configmanagement {
    config_sync {
      metrics_gcp_service_account_email = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccCloudbuildWorkerPool_withNetwork [Error message] [Debug log]
TestAccClouddeployTarget_Target [Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4306
Passed tests: 3895
Skipped tests: 407
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccClouddeployTarget_withAttributionDisabled
  • TestAccClouddeployTarget_withCreationOnlyAttribution
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccClouddeployTarget_withAttributionDisabled [Debug log]
TestAccClouddeployTarget_withCreationOnlyAttribution [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy [Error message] [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 566 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 14 files changed, 571 insertions(+), 98 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature_membership (17 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  configmanagement {
    config_sync {
      metrics_gcp_service_account_email = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4308
Passed tests: 3898
Skipped tests: 407
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeDeveloper_apigeeDeveloperUpdateTest
  • TestAccParallelstoreInstance_parallelstoreInstanceBasicExample
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccApigeeDeveloper_apigeeDeveloperUpdateTest [Debug log]
TestAccParallelstoreInstance_parallelstoreInstanceBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@haiyanmeng
Copy link
Contributor

gkehub: added configmanagement.config_sync. stop_syncing field to google_gke_hub_feature_membership resource

@zli82016 , please remove the extra space: configmanagement.config_sync. stop_syncing to configmanagement.config_sync.stop_syncing

@zli82016 zli82016 requested review from a team and rileykarson and removed request for a team November 25, 2024 17:29
@zli82016
Copy link
Member Author

The failed test TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample is unrelated.

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

github-actions bot commented Dec 2, 2024

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

haiyanmeng added a commit to haiyanmeng/magic-modules that referenced this pull request Dec 3, 2024
This field was added to `google_gke_hub_feature_membership` resource in
DCL 1.76.0:
GoogleCloudPlatform#12392.
haiyanmeng added a commit to haiyanmeng/magic-modules that referenced this pull request Dec 3, 2024
This field was added to `google_gke_hub_feature_membership` resource in
DCL 1.76.0:
GoogleCloudPlatform#12392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants