Expand Terraform for Developer Connect #12391

ihnarayanan · 2024-11-21T21:40:53Z

fixes hashicorp/terraform-provider-google#20737

developerconnect: added `crypto_key_config`, `github_enterprise_config`, `gitlab_config` , and `gitlab_enterprise_config` fields to `google_developer_connect_connection` resource (beta)

`google_developer_connect_git_repository_link` (ga)

`google_developer_connect_connection` (ga)

modular-magician · 2024-11-21T21:51:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4065 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2109 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 941 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-21T21:54:08Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample

TestAccDeveloperConnectConnection_update

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample

Get to know how VCR tests work

modular-magician · 2024-11-21T21:54:46Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:01:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4128 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2172 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 947 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-25T17:04:10Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample

TestAccDeveloperConnectConnection_update

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample

Get to know how VCR tests work

modular-magician · 2024-11-25T17:04:47Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T17:42:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4128 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2172 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 947 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-25T17:45:09Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample

TestAccDeveloperConnectConnection_update

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample

Get to know how VCR tests work

modular-magician · 2024-11-25T17:45:37Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-11-25T21:21:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4143 insertions(+), 98 deletions(-))
google-beta provider: Diff ( 7 files changed, 2187 insertions(+), 283 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 525 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 947 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference
Field installation_state MinItems went from unset to 1 on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    app_id                     = # value needed
    private_key_secret_version = # value needed
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate            = # value needed
    webhook_secret_secret_version = # value needed
  }
  gitlab_enterprise_config {
    authorizer_credential {
      user_token_secret_version = # value needed
    }
    read_authorizer_credential {
      user_token_secret_version = # value needed
    }
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-11-25T21:23:32Z

Tests analytics

Total tests: 9
Passed tests: 0
Skipped tests: 0
Affected tests: 9

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample

TestAccDeveloperConnectConnection_update

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample

Get to know how VCR tests work

modular-magician · 2024-11-25T21:24:01Z

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_update [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-03T16:24:59Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4077 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 6 files changed, 2074 insertions(+), 218 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 960 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  gitlab_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-12-03T16:27:20Z

Tests analytics

Total tests: 9
Passed tests: 2
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample

Get to know how VCR tests work

modular-magician · 2024-12-03T16:28:26Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-05T17:11:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 17 files changed, 4085 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 6 files changed, 2082 insertions(+), 218 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 964 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  gitlab_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  labels = # value needed
}

Resource: google_developer_connect_git_repository_link (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_git_repository_link" "primary" {
  labels = # value needed
}

modular-magician · 2024-12-05T17:14:17Z

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample

Get to know how VCR tests work

modular-magician · 2024-12-05T17:15:10Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-12-09T02:05:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4383 insertions(+), 79 deletions(-))
google-beta provider: Diff ( 7 files changed, 2312 insertions(+), 226 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  annotations = # value needed
  crypto_key_config {
    key_reference = # value needed
  }
  etag = # value needed
  github_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  gitlab_enterprise_config {
    service_directory_config {
      service = # value needed
    }
    ssl_ca_certificate = # value needed
  }
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
  labels = # value needed
}

modular-magician · 2024-12-09T02:08:00Z

Tests analytics

Total tests: 12
Passed tests: 8
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate

Get to know how VCR tests work

modular-magician · 2024-12-09T02:09:03Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-12-13T19:15:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4490 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 7 files changed, 2422 insertions(+), 230 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 463 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field etag became Computed only on google_developer_connect_connection - reference
Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2024-12-13T19:17:55Z

Tests analytics

Total tests: 14
Passed tests: 8
Skipped tests: 0
Affected tests: 6

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_GhePrivConnection

TestAccDeveloperConnectConnection_GlePrivConnection

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate

Get to know how VCR tests work

modular-magician · 2024-12-13T19:19:09Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_GhePrivConnection [Error message] [Debug log]
TestAccDeveloperConnectConnection_GlePrivConnection [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-12-16T19:52:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4494 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 7 files changed, 2426 insertions(+), 230 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 463 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 32 files changed, 968 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field etag became Computed only on google_developer_connect_connection - reference
Field installation_state.action_uri became Computed only on google_developer_connect_connection - reference
Field installation_state.message became Computed only on google_developer_connect_connection - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2024-12-16T19:54:54Z

Tests analytics

Total tests: 14
Passed tests: 12
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_GhePrivConnection

TestAccDeveloperConnectConnection_GlePrivConnection

Get to know how VCR tests work

modular-magician · 2024-12-16T19:55:46Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_GhePrivConnection [Debug log]
TestAccDeveloperConnectConnection_GlePrivConnection [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

ihnarayanan · 2024-12-18T17:01:56Z

Is a Github issue for this PR? Thanks.

hashicorp/terraform-provider-google#20737

zli82016 · 2024-12-18T17:23:55Z

Is a Github issue for this PR? Thanks.

hashicorp/terraform-provider-google#20737

Thanks, I added the Github issue to the description section of this PR

mmv1/products/developerconnect/GitRepositoryLink.yaml

modular-magician · 2024-12-18T18:22:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4312 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 6 files changed, 2199 insertions(+), 170 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 20 files changed, 586 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-18T18:25:20Z

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

modular-magician · 2024-12-18T18:26:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4312 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 6 files changed, 2199 insertions(+), 170 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 20 files changed, 586 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (18 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2024-12-18T18:29:10Z

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample
🟢 All tests passed!

View the build log

zli82016 · 2024-12-19T19:25:05Z

Can you resolve the conflicts? Thanks.

...party/terraform/services/developerconnect/resource_developer_connect_connection_test.go.tmpl

mmv1/products/developerconnect/Connection.yaml

github-actions · 2025-01-02T09:41:24Z

@ihnarayanan, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

modular-magician · 2025-01-06T17:25:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4429 insertions(+), 73 deletions(-))
google-beta provider: Diff ( 6 files changed, 2270 insertions(+), 203 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 24 files changed, 704 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2025-01-06T17:27:45Z

Tests analytics

Total tests: 12
Passed tests: 9
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate

TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate

Get to know how VCR tests work

modular-magician · 2025-01-06T17:28:47Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-06T18:41:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 4429 insertions(+), 73 deletions(-))
google-beta provider: Diff ( 6 files changed, 2270 insertions(+), 203 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 473 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 24 files changed, 704 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

modular-magician · 2025-01-06T18:44:31Z

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

developerconnect

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate

Get to know how VCR tests work

modular-magician · 2025-01-06T18:45:33Z

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

ihnarayanan · 2025-01-06T19:22:28Z

Resolved conflicts and added field updates.

zli82016

LGTM

modular-magician added the service/developerconnect label Nov 21, 2024

ihnarayanan force-pushed the dc-terraform branch from 9d4604d to 24c628c Compare December 13, 2024 18:54

ihnarayanan force-pushed the dc-terraform branch from a08aaa0 to dd286ee Compare December 16, 2024 19:29

github-actions bot requested a review from zli82016 December 18, 2024 17:02

zli82016 reviewed Dec 18, 2024

View reviewed changes

mmv1/products/developerconnect/GitRepositoryLink.yaml Outdated Show resolved Hide resolved

github-actions bot requested a review from zli82016 December 18, 2024 18:12

zli82016 requested changes Dec 19, 2024

View reviewed changes

Adding field updates after code review

aa57352

ihnarayanan force-pushed the dc-terraform branch from 5c5268f to aa57352 Compare January 6, 2025 17:14

github-actions bot requested a review from zli82016 January 6, 2025 17:14

Fix yaml formatting

7c0b08e

zli82016 approved these changes Jan 6, 2025

View reviewed changes

zli82016 merged commit 5ee445e into GoogleCloudPlatform:main Jan 6, 2025
15 checks passed

dkarwowski pushed a commit to dkarwowski/magic-modules that referenced this pull request Jan 7, 2025

Expand Terraform for Developer Connect (GoogleCloudPlatform#12391)

023b575

Expand Terraform for Developer Connect #12391

Expand Terraform for Developer Connect #12391

Conversation

ihnarayanan commented Nov 21, 2024 • edited by zli82016 Loading

modular-magician commented Nov 21, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 21, 2024

Tests analytics

Action taken

modular-magician commented Nov 21, 2024

modular-magician commented Nov 25, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Nov 25, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Nov 25, 2024

Tests analytics

Action taken

modular-magician commented Nov 25, 2024

modular-magician commented Dec 3, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Dec 3, 2024

Tests analytics

Action taken

modular-magician commented Dec 3, 2024

modular-magician commented Dec 5, 2024

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Dec 5, 2024

Tests analytics

Action taken

modular-magician commented Dec 5, 2024

modular-magician commented Dec 9, 2024

Diff report

Missing test report

modular-magician commented Dec 9, 2024

Tests analytics

Action taken

modular-magician commented Dec 9, 2024

modular-magician commented Dec 13, 2024

Diff report

Breaking Change(s) Detected

modular-magician commented Dec 13, 2024

Tests analytics

Action taken

modular-magician commented Dec 13, 2024

modular-magician commented Dec 16, 2024

Diff report

Breaking Change(s) Detected

modular-magician commented Dec 16, 2024

Tests analytics

Action taken

modular-magician commented Dec 16, 2024

ihnarayanan commented Dec 18, 2024

zli82016 commented Dec 18, 2024

modular-magician commented Dec 18, 2024

Diff report

Missing test report

modular-magician commented Dec 18, 2024

Tests analytics

ihnarayanan commented Nov 21, 2024 •

edited by zli82016

Loading