Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled #12375

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 104
Passed tests: 88
Skipped tests: 15
Affected tests: 1

Click here to see the affected service packages
  • sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 requested review from a team and hao-nan-li and removed request for a team November 20, 2024 20:54
@zli82016 zli82016 merged commit 8e3d358 into GoogleCloudPlatform:main Nov 21, 2024
13 checks passed
@zli82016 zli82016 deleted the TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled branch November 21, 2024 17:40
SarahFrench pushed a commit to SarahFrench/magic-modules that referenced this pull request Nov 21, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants