Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait for SA to propagate on beyondcord app #12365

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

ScottSuarez
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@ScottSuarez
Copy link
Contributor Author

close attempt on hashicorp/terraform-provider-google#19754

I believe this will fix the issue as per b/372032894#comment3

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 105 insertions(+), 37 deletions(-))
google-beta provider: Diff ( 4 files changed, 105 insertions(+), 37 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 13
Skipped tests: 0
Affected tests: 5

Click here to see the affected service packages
  • beyondcorp

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionFullExample
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionUpdateExample
  • TestAccDataSourceGoogleBeyondcorpAppConnection_basic
  • TestAccDataSourceGoogleBeyondcorpAppConnection_full

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionFullExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionUpdateExample [Error message] [Debug log]
TestAccDataSourceGoogleBeyondcorpAppConnection_basic [Error message] [Debug log]
TestAccDataSourceGoogleBeyondcorpAppConnection_full [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 121 insertions(+), 41 deletions(-))
google-beta provider: Diff ( 4 files changed, 121 insertions(+), 41 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 17
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • beyondcorp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionUpdateExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionUpdateExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 125 insertions(+), 42 deletions(-))
google-beta provider: Diff ( 4 files changed, 125 insertions(+), 42 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • beyondcorp

🟢 All tests passed!

View the build log

@ScottSuarez
Copy link
Contributor Author

hi @zli82016 this is ready for review - but no rush!

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants