Fix identity type comparison for service perimeters

[coder-221]

Fixes hashicorp/terraform-provider-google/issues/17023. The API does not return the IDENTITY_TYPE_UNSPECIFIED enum value when it is set so we can treat that as an empty value.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

accesscontextmanager: fixed comparison of `identity_type` in `ingress_from` and `egress_from` when the `IDENTITY_TYPE_UNSPECIFIED` is set

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 176 insertions(+), 28 deletions(-))
google-beta provider: Diff ( 6 files changed, 176 insertions(+), 28 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 53 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identity_type = # value needed
  }
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identity_type = # value needed
  }
}

Resource: google_access_context_manager_service_perimeter_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_egress_policy" "primary" {
  egress_from {
    identity_type = # value needed
  }
}

Resource: google_access_context_manager_service_perimeter_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_ingress_policy" "primary" {
  ingress_from {
    identity_type = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 4
Passed tests: 1
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages

• accesscontextmanager

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[slevenick]

This is a good demonstration on why we shouldn't allow the _UNSPECIFIED enum value to be specified in Terraform!