Remove policycontroller block from ACM configmanagement in gkehub_feature_membership tests #12166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests analyticsTotal tests: 11 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
Tests passed in Teamcity |
zli82016
requested review from
a team and
SirGitsalot
and removed request for
a team
SirGitsalot
approved these changes
Oct 30, 2024
zli82016
changed the title
zli82016
deleted the
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
branch
This was referenced Oct 30, 2024
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Nov 1, 2024
…ture_membership tests (GoogleCloudPlatform#12166)
BBBmau
pushed a commit
to BBBmau/magic-modules
that referenced
this pull request
Nov 5, 2024
…ture_membership tests (GoogleCloudPlatform#12166)
akshat-jindal-nit
pushed a commit
to akshat-jindal-nit/magic-modules
that referenced
this pull request
Nov 18, 2024
…ture_membership tests (GoogleCloudPlatform#12166)
amanMahendroo
pushed a commit
to amanMahendroo/magic-modules
that referenced
this pull request
Dec 17, 2024
…ture_membership tests (GoogleCloudPlatform#12166)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the permadiff in
policy_controllerfield insideconfigmanagement(hashicorp/terraform-provider-google#14591 (comment))Copying data of
policycontrollerinto ACM is async and the non-atomic operation caused the permadiff inpolicy_controllerfield insideconfigmanagement.As
policycontrolleris deprecated inside ACM, it is going to be removed fromconfigmanagementin the ACM tests.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.