Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DCL to 1.75.0 #12046

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Upgrade DCL to 1.75.0 #12046

merged 3 commits into from
Oct 23, 2024

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Oct 17, 2024

Release Note Template for Downstream PRs (will be copied)

assuredworkloads: added `workload_options` field to `google_assured_workloads_workload` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 69 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 4 files changed, 69 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_assured_workloads_workload (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_assured_workloads_workload" "primary" {
  workload_options {
    kaj_enrollment_type = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 73 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 4 files changed, 73 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_assured_workloads_workload (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_assured_workloads_workload" "primary" {
  workload_options {
    kaj_enrollment_type = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4196
Passed tests: 3776
Skipped tests: 418
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
  • TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]
🔴 Tests failed when rerunning REPLAYING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 76 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 5 files changed, 76 insertions(+), 7 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_assured_workloads_workload (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_assured_workloads_workload" "primary" {
  workload_options {
    kaj_enrollment_type = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3775
Skipped tests: 420
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccDataLossPreventionDiscoveryConfig_Update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 76 insertions(+), 7 deletions(-))
google-beta provider: Diff ( 5 files changed, 76 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccDataLossPreventionDiscoveryConfig_Update[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3776
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAssuredWorkloadsWorkload_BasicHandWritten
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAssuredWorkloadsWorkload_BasicHandWritten [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3776
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAssuredWorkloadsWorkload_BasicHandWritten
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAssuredWorkloadsWorkload_BasicHandWritten [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 79 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 5 files changed, 82 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4198
Passed tests: 3776
Skipped tests: 420
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAssuredWorkloadsWorkload_BasicHandWritten
  • TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAssuredWorkloadsWorkload_BasicHandWritten [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016
Copy link
Member Author

The failed test TestAccBigqueryConnectionConnection_bigqueryConnectionKmsExample is unrelated.

@zli82016 zli82016 requested review from a team and slevenick and removed request for a team October 18, 2024 16:54
@zli82016
Copy link
Member Author

Rebased the main branch to resolve the conflicts.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 79 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 5 files changed, 82 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4206
Passed tests: 3785
Skipped tests: 420
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBackupDRBackupVault_fullUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@zli82016 zli82016 merged commit 7c1c0c3 into GoogleCloudPlatform:main Oct 23, 2024
10 checks passed
@zli82016 zli82016 deleted the dcl-1.75.0 branch October 23, 2024 17:01
himanikh pushed a commit to himanikh/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants