Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container node pool empty guest accelerator #12027

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Oct 17, 2024

fixes hashicorp/terraform-provider-google#19536

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 28 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 2 files changed, 28 insertions(+), 12 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 26 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 26 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 212
Passed tests: 199
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 212
Passed tests: 199
Skipped tests: 13
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@trodge
Copy link
Contributor Author

trodge commented Oct 17, 2024

It looks like this never failed in VCR because we never recorded a cassette that includes gpuDriverInstallationConfig in an API response, but I have run the test locally and it passes.

The GET response looks like this:

{
 "name": "tf-test-nodepool-j4u0laao4s",
 "config": {
  "machineType": "n1-highmem-4",
  "diskSizeGb": 100,
  "oauthScopes": [
   "https://www.googleapis.com/auth/devstorage.read_only",
   "https://www.googleapis.com/auth/logging.write",
   "https://www.googleapis.com/auth/monitoring",
   "https://www.googleapis.com/auth/service.management.readonly",
   "https://www.googleapis.com/auth/servicecontrol",
   "https://www.googleapis.com/auth/trace.append"
  ],
  "metadata": {
   "disable-legacy-endpoints": "true"
  },
  "imageType": "COS_CONTAINERD",
  "serviceAccount": "default",
  "accelerators": [
   {
    "acceleratorCount": "1",
    "acceleratorType": "nvidia-tesla-p100",
    "gpuDriverInstallationConfig": {
     "gpuDriverVersion": "DEFAULT"
    }
   }
  ],
  "diskType": "pd-balanced",
  "taints": [
   {
    "key": "nvidia.com/gpu",
    "value": "present",
    "effect": "NO_SCHEDULE"
   }
  ],
  "shieldedInstanceConfig": {
   "enableIntegrityMonitoring": true
  },
  "loggingConfig": {},
  "windowsNodeConfig": {},
  "effectiveCgroupMode": "EFFECTIVE_CGROUP_MODE_V2"
 },
 "initialNodeCount": 1,
 "management": {
  "autoUpgrade": true,
  "autoRepair": true
 },
 "maxPodsConstraint": {
  "maxPodsPerNode": "110"
 },
 "podIpv4CidrSize": 24,
 "locations": [
  "us-central1-f"
 ],
 "networkConfig": {
  "podRange": "gke-tf-test-cluster-aj0pqjb0g7-pods-35127882",
  "podIpv4CidrBlock": "10.20.0.0/14"
 },
 "selfLink": "https://container.googleapis.com/v1beta1/projects/tjr-dm-test-6/zones/us-central1-f/clusters/tf-test-cluster-aj0pqjb0g7/nodePools/tf-test-nodepool-j4u0laao4s",
 "version": "1.30.5-gke.1014001",
 "instanceGroupUrls": [
  "https://www.googleapis.com/compute/v1/projects/tjr-dm-test-6/zones/us-central1-f/instanceGroupManagers/gke-tf-test-cluster--tf-test-nodepool-10900ad4-grp"
 ],
 "status": "RUNNING",
 "upgradeSettings": {
  "maxSurge": 1,
  "strategy": "SURGE"
 },
 "etag": "ac0bc486-8657-448e-8efc-2b0d31181498"
}

@trodge trodge marked this pull request as ready for review October 17, 2024 19:46
@trodge trodge requested a review from shuyama1 October 17, 2024 19:46
@trodge trodge merged commit 91654fd into GoogleCloudPlatform:main Oct 17, 2024
11 checks passed
@trodge trodge deleted the container-node-pool-empty-guest-accelerator branch October 17, 2024 22:42
varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 21, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccContainerNodePool_EmptyGuestAccelerator
3 participants