Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample #11986

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Oct 11, 2024

fixes hashicorp/terraform-provider-google#16170

After discussed with the service team, the reason for the internal error is that on the API side one behavior has changed with the resource google_storage_bucket resource, that now for the test requires uniform_bucket_level_access = true.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+))
google-beta provider: Diff ( 2 files changed, 2 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1028
Passed tests: 953
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016 zli82016 requested review from a team and hao-nan-li and removed request for a team October 11, 2024 17:36
@zli82016 zli82016 merged commit 5f35568 into GoogleCloudPlatform:main Oct 11, 2024
14 checks passed
@zli82016 zli82016 deleted the fix-TestAccComputeRegionNetworkEndpointGroup branch October 11, 2024 17:44
chayankumar999 pushed a commit to chayankumar999/magic-modules that referenced this pull request Oct 11, 2024
chayankumar999 added a commit to chayankumar999/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample
3 participants