Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test that fails in replaying #11796

Merged

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Sep 24, 2024

Helps with hashicorp/terraform-provider-google#19592

Skipping this test in VCR for now until we figure out why it fails in replaying.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networkconnectivity

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went to make an issue about this and saw the one you opened - thanks for addressing this!

@trodge trodge merged commit 2951218 into GoogleCloudPlatform:main Sep 24, 2024
13 checks passed
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 26, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants