Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go rewrite tgc handwritten files #11768

Merged

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 19, 2024

There are not diffs when running the command locally.

Steps to test tgc provider locally:

  1. Remove the generated files from terraform-google-conversion by running the command
rm -rf tfplan2cai/ancestrymanager; rm -rf tfplan2cai/converters/google; rm -rf tfplan2cai/test
  1. Generate the tgc provider from magic-modules and no files are missing in terraform-google-conversion
cd mmv1;
go run . --version beta --output $GOPATH/src/github.com/GoogleCloudPlatform/terraform-google-conversion/tfplan2cai --provider  tgc

Steps to test tgc cai2hcl provider locally:

  1. Remove the generated files from terraform-google-conversion by running the command
rm -rf cai2hcl
  1. Generate the tgc provider from magic-modules and no files are missing in terraform-google-conversion
cd mmv1;
go run . --version beta --output $GOPATH/src/github.com/GoogleCloudPlatform/terraform-google-conversion/cai2hcl --provider  tgc_cai2hcl

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@zli82016 zli82016 requested a review from c2thorn September 20, 2024 03:01
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@zli82016 zli82016 merged commit 3a42912 into GoogleCloudPlatform:main Sep 20, 2024
10 checks passed
@zli82016 zli82016 deleted the go-rewrite-tgc-handwritten branch September 20, 2024 16:06
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants