Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test TestAccDataflowJob_withProviderDefaultLabels #11757

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Sep 19, 2024

terraform_labels merges the provider default labels and the labels configured on the resource through Terraform.
effective_labels has all of the labels on the resource.

In the provider release 6.0, a new revenue label is added to the provider default labels by default, so terraform_labels and effective_labels should have one more label.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016 zli82016 force-pushed the fix-TestAccDataflowJob branch from 8d1749f to 2be96f7 Compare September 19, 2024 20:31
@zli82016 zli82016 force-pushed the fix-TestAccDataflowJob branch from 2be96f7 to 192f7cc Compare September 19, 2024 20:33
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 8 insertions(+), 8 deletions(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 8 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 8 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 8 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 26
Passed tests: 0
Skipped tests: 26
Affected tests: 0

Click here to see the affected service packages
  • dataflow

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016 zli82016 requested review from a team and slevenick and removed request for a team September 20, 2024 15:58
@zli82016 zli82016 merged commit 7f1b8e6 into GoogleCloudPlatform:main Sep 20, 2024
11 checks passed
@zli82016 zli82016 deleted the fix-TestAccDataflowJob branch September 20, 2024 16:34
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants