-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource Dataproc batch #11750
Add resource Dataproc batch #11750
Conversation
299864d
to
3c7b7f1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
48cafb0
to
5e6a92d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
5e6a92d
to
45ae494
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
6672fee
to
a7c65dc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Fix tests Address comments Rename resource_dataproc_batch_test.go to resource_dataproc_batch_test.go.erb Fixed package name & switched to func Fixed imports & test file name Fixed function names Fix PR review comments Fixed yaml lint errors Add a test for SparkR batch Resolve version and properties permadiff for batch resource Add more fields to test examples Resolve peripheral_configs permadiff. Making fields exatly_one_off/ Bootstrap new subnet with firewall for Dataproc Batches Added utility method to bootstrap subnet for Dataproc batches Added utility method to bootstrap subnet for Dataproc batches Updated async block for batch resource. Terraform Support for Dataproc Batches.
a7c65dc
to
56facfa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
If they can get it set up before merge that would definitely be preferable, but I think we can go ahead otherwise if the overall resource works. There's just a higher risk of bugs. |
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_batch" "primary" {
runtime_config {
container_image = # value needed
}
spark_batch {
archive_uris = # value needed
file_uris = # value needed
main_jar_file_uri = # value needed
}
spark_r_batch {
archive_uris = # value needed
file_uris = # value needed
}
}
|
This comment was marked as outdated.
This comment was marked as outdated.
Tests analyticsTotal tests: 4105 Click here to see the affected service packages
Tests were added that are skipped in VCR:
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Adding the tests would be great if it works out before the next cut, otherwise it's probably fine to go ahead with this.
Actually it would be great to merge this Monday if possible (at the latest) |
I am going to merge this PR now and add the missing test later. |
fixes hashicorp/terraform-provider-google#11775
Release Note Template for Downstream PRs (will be copied)