Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go rewrite tgc iam converter template and handwritten test files #11740

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

zli82016
Copy link
Member

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 changed the title Go rewrite tgc templates and test files Go rewrite tgc iam converter template and test files Sep 17, 2024
@zli82016 zli82016 changed the title Go rewrite tgc iam converter template and test files Go rewrite tgc iam converter template and handwritten test files Sep 17, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 450 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 4 files changed, 450 insertions(+), 14 deletions(-))

@c2thorn c2thorn self-requested a review September 18, 2024 21:37
@zli82016
Copy link
Member Author

I run the command to generate tgc locally and there are no diffs for the files that have been migrated to Go.

Three folders are generated from magic modules to the TGC provider.

  • tfplan2cai/ancestrymanager
  • tfplan2cai/converters/google
  • tfplan2cai/test

This is the current progress.

  • On the left side are all of the files generated into TGC. (I delete these three folders in tgc locally to get the list of files.)
  • On the right side are the remaining files that need to be converted.
  • The diffs are the files that been converted (I generate the files with the go command line)

mmv1/google/slice_utils.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants