Cleanup Go rewrite TODOs and remove unused fields #11648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zli82016
changed the title
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
cc @c2thorn |
This was referenced Sep 6, 2024
Merged
entertvl
pushed a commit
to entertvl/magic-modules
that referenced
this pull request
Sep 9, 2024
iyabchen
pushed a commit
to iyabchen/magic-modules
that referenced
this pull request
Sep 14, 2024
abd-goog
pushed a commit
to abd-goog/magic-modules
that referenced
this pull request
Sep 23, 2024
niharika-98
pushed a commit
to niharika-98/magic-modules
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO rewritefor remaining TODOsNamedObjectobject, as only two fieldsNameandApiNameare inside the object. It is not so useful to use the embedded object.validateLabelsFieldto validate labels fieldPatternfromTypeobjectCustomPollReadfromPollAsyncobjectRelease Note Template for Downstream PRs (will be copied)