Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go rewrite - general refresh and diffs 9/3 #11626

Merged
merged 7 commits into from
Sep 3, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 3, 2024

separated the changes out by commit

  • full service refresh
  • There was a bug in the versioning where many beta-only test files were not being generated.
  • other minor diffs

the diff generated after running go run . --version beta --output /Users/camthornton/terraform-provider-google-beta
c2thorn/terraform-provider-google-beta@468a149

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 16 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 18 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@c2thorn c2thorn requested a review from NickElliot September 3, 2024 19:27
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 40
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • redis
  • servicemanagement
  • tpu
  • datastream
  • parallelstore

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 16 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 18 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 16 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 9 files changed, 18 insertions(+), 8 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 40
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • datastream
  • parallelstore
  • redis
  • servicemanagement
  • tpu

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 40
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages
  • datastream
  • parallelstore
  • redis
  • servicemanagement
  • tpu

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diffs look good, I should've caught that change on the redis examples where I updated the new templates to use the correct logic but not the old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants