Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger for downstream generation and test #11465

Merged

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Aug 15, 2024

Apart of community checker removal
Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez requested a review from melinath August 15, 2024 23:53
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently cloudbuild doesn't like secrets that are defined but unused. (which I guess makes sense)

@ScottSuarez ScottSuarez requested a review from melinath August 16, 2024 15:50
@ScottSuarez
Copy link
Contributor Author

Added to the secret env list

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the noise; looks like it's still failing but I don't see a clear error

@ScottSuarez
Copy link
Contributor Author

/gcbrun

I think I know what happened. Need to grant the SA access

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez ScottSuarez requested a review from melinath August 16, 2024 16:44
@ScottSuarez ScottSuarez merged commit ea4c179 into GoogleCloudPlatform:main Aug 16, 2024
8 checks passed
@ScottSuarez ScottSuarez deleted the downstream-gen-trigger branch August 16, 2024 17:39
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants