Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tgc unit test #11434

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Aug 13, 2024

Unit test passed locally.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 144
Passed tests: 114
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

@zli82016 zli82016 changed the base branch from FEATURE-BRANCH-major-release-6.0.0 to main August 13, 2024 17:02
@zli82016 zli82016 closed this Aug 13, 2024
@zli82016 zli82016 reopened this Aug 13, 2024
@zli82016 zli82016 changed the base branch from main to FEATURE-BRANCH-major-release-6.0.0 August 13, 2024 18:05
@zli82016 zli82016 changed the title test Fix tgc unit test Aug 13, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 1 file changed, 1 deletion(-))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 1 file changed, 1 deletion(-))

@zli82016 zli82016 requested review from a team, slevenick and roaks3 and removed request for a team and slevenick August 13, 2024 18:30
@zli82016 zli82016 merged commit 2f02fec into GoogleCloudPlatform:FEATURE-BRANCH-major-release-6.0.0 Aug 14, 2024
8 checks passed
@zli82016 zli82016 deleted the fix-project-delete branch August 14, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants