Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set disbaleSsh default value to true for workstation create #11225

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Set disbaleSsh default value to true for workstation create #11225

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79750f1
Set disbaleSsh default value to true for workstation create
tejal29 Jul 22, 2024
cfc7633
add deprecation notes
tejal29 Aug 9, 2024
ee1d06e
Apply suggestions from code review
c2thorn Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mmv1/products/workstations/WorkstationConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ properties:
Whether instances have no public IP address.
- !ruby/object:Api::Type::Boolean
name: 'disableSsh'
default_value: true
send_empty_value: true
description: |
Whether to disable SSH access to the VM.
- !ruby/object:Api::Type::Boolean
Expand Down
6 changes: 6 additions & 0 deletions mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,12 @@ on the resource through Terraform and the default labels configured on the provi
* The new output-only `effective_labels` field lists all of labels present on the resource
in GCP, including the labels configured through Terraform, the system, and other clients.

## Resource: `google_workstations_workstation_config`

### Disable SSH to root VM is set to true by default for workstation config.
c2thorn marked this conversation as resolved.
Show resolved Hide resolved

* `disableSSH` field is set to true when creating configs. To enable SSH, please set `disableSSH` to false.
c2thorn marked this conversation as resolved.
Show resolved Hide resolved

## Removals

### Resource: `google_identity_platform_project_default_config` is now removed
Expand Down
Loading