Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipVersion field to support IPv6 in global address and release to Terraform #110

Merged
merged 7 commits into from
Apr 27, 2018
Merged

Add ipVersion field to support IPv6 in global address and release to Terraform #110

merged 7 commits into from
Apr 27, 2018

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Apr 24, 2018

  • Add new ipVersion field.
  • Add documentation links to GlobalAddress
  • Tweak property documentation to remove the mention of some fields being only allowed in global address. It is redundant. This resource is GlobalAddress. There is a different resource for Address
  • Terraform
    • Support Enum validation
    • Release generated GlobalAddress

[all]

[terraform]

Release generated GlobalAddress

[puppet]

[puppet-dns]

[puppet-compute]

Add ipVersion property to support IPv6

[chef]

@rosbo rosbo requested review from nelsonjr and removed request for nelsonjr April 24, 2018 23:25
@rosbo rosbo requested a review from nelsonjr April 25, 2018 16:23
@rosbo rosbo assigned nat-henderson and unassigned danawillow Apr 25, 2018
@modular-magician
Copy link
Collaborator

modular-magician commented Apr 25, 2018 •
edited by rosbo
Loading

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#1379
depends: GoogleCloudPlatform/puppet-google-compute#14

nelsonjr
nelsonjr reviewed Apr 25, 2018
View reviewed changes
products/compute/terraform.yaml Outdated
@@ -344,6 +349,9 @@ files: !ruby/object:Provider::Config::Files
'google/transport_test.go': 'templates/terraform/transport_test.go'
'google/import.go': 'templates/terraform/import.go'
'google/import_test.go': 'templates/terraform/import_test.go'
# Handwritten acceptance tests for autogenerated resources.
# Adding them here allows updating the tests as part of a MM pull request.
'google/resource_compute_global_address_test.go': 'templates/terraform/tests/resource_compute_global_address_test.go'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep the YAML files 80-chars. It works well if you break this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

nelsonjr
nelsonjr reviewed Apr 25, 2018
View reviewed changes
products/compute/api.yaml Outdated
@@ -899,6 +899,10 @@ objects:
description: |
Represents a Global Address resource. Global addresses are used for
HTTP(S) load balancing.
references: !ruby/object:Api::Resource::ReferenceLinks
guides:
'Reserving a Static External IP Address': 'https://cloud.google.com/compute/docs/ip-addresses/reserve-static-external-ip-address'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break line at ":"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rosbo rosbo force-pushed the tf-global-address branch 2 times, most recently from 5e1dc15 to f7b0a04 Compare April 26, 2018 18:23
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit f7b0a04) have been included in your existing downstream PRs.

@rosbo rosbo force-pushed the tf-global-address branch from f7b0a04 to 7b050e4 Compare April 26, 2018 18:51
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 7b050e4) have been included in your existing downstream PRs.

@nelsonjr
Copy link
Contributor

LGTM.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit f39cbae) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 788632f) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit e6c35de) have been included in your existing downstream PRs.

@rosbo rosbo force-pushed the tf-global-address branch from e6c35de to b0b8b48 Compare April 27, 2018 22:25
@rosbo rosbo merged commit 62d83dc into master Apr 27, 2018
@rosbo rosbo deleted the tf-global-address branch April 27, 2018 22:26
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit b0b8b48) have been included in your existing downstream PRs.

@modular-magician modular-magician mentioned this pull request Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonjr nelsonjr nelsonjr left review comments

@nat-henderson nat-henderson nat-henderson approved these changes

Assignees

@nat-henderson nat-henderson

@nelsonjr nelsonjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosbo @modular-magician @nelsonjr @nat-henderson @danawillow