Make google_vpc_access_connector acc tests use a bootstrapped VPC network

[SarahFrench]

This is to address some CIDR related test failures: #10313 (comment)

Release Note Template for Downstream PRs (will be copied)

[SarahFrench]

Or I could name this "vpcaccess", instead of "vpc-access-connector", and then if any other vpcaccess acceptance tests need to use a special VPC they can use the same, service-wide bootstrapped VPC? I'm not sure what the intended usage of BootstrapSharedServiceNetworkingConnection is.

[roaks3]

I think what you have is probably fine. Unless things have changed significantly, anything using bootstrapped networks generally needs to use a per-test id.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 5 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 13 deletions(-))
Open in Cloud Shell: Diff ( 2 files changed, 2 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• vpcaccess

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVPCAccessConnector_vpcAccessConnectorExample[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[roaks3]

I think what you have is probably fine. Unless things have changed significantly, anything using bootstrapped networks generally needs to use a per-test id.

[SarahFrench]

Thanks!