Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Remove beta fields from GA Container resources #1008

Conversation

rileykarson
Copy link
Member

Part of hashicorp/terraform-provider-google#1203

No tests failed (and several finished + passed) before I inadvertently closed my laptop and ended them all, so I'm happy with that. If there's an issue, CI will catch it long before 2.0.0.


[all]

[terraform]

Remove beta fields from GA Container resources

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#194
depends: hashicorp/terraform-provider-google#2601

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some comments in the tests about adding an import step or merging with other tests. Since we can import beta things now, mind taking care of that?

@rileykarson
Copy link
Member Author

Done

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 1ff57ad) have been included in your existing downstream PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants