Add HTTPS health check to InSpec (#1305)

Merged PR #1305.

products/compute/inspec.yaml

@@ -35,8 +35,6 @@ overrides: !ruby/object:Overrides::ResourceOverrides
     exclude: true
   GlobalForwardingRule: !ruby/object:Overrides::Inspec::ResourceOverride
     exclude: true
-  HttpsHealthCheck: !ruby/object:Overrides::Inspec::ResourceOverride
-    exclude: true
   Image: !ruby/object:Overrides::Inspec::ResourceOverride
     exclude: true
   Instance: !ruby/object:Overrides::Inspec::ResourceOverride

templates/inspec/examples/attributes/google_compute_https_health_check.erb

@@ -0,0 +1,2 @@
+gcp_project_id = attribute(:gcp_project_id, default: '<%= external_attribute('gcp_project_id') -%>', description: 'The GCP project identifier.')
+https_health_check = attribute('https_health_check', default: <%= JSON.pretty_generate(grab_attributes['https_health_check']) -%>, description: 'HTTPS health check definition')

templates/inspec/examples/google_compute_https_health_check.erb

@@ -0,0 +1,13 @@
+<% gcp_project_id = "#{external_attribute('gcp_project_id', doc_generation)}" -%>
+<% https_health_check = grab_attributes['https_health_check'] -%>
+describe google_compute_https_health_check(project: <%= doc_generation ? "#{gcp_project_id}" : "gcp_project_id" -%>, name: <%= doc_generation ? "'#{https_health_check['name']}'" : "https_health_check['name']" -%>) do
+  it { should exist }
+  its('timeout_sec') { should eq <%= doc_generation ? "'#{https_health_check['timeout_sec']}'" : "https_health_check['timeout_sec']" -%> }
+  its('request_path') { should eq <%= doc_generation ? "'#{https_health_check['request_path']}'" : "https_health_check['request_path']" -%> }
+  its('check_interval_sec') { should eq <%= doc_generation ? "'#{https_health_check['check_interval_sec']}'" : "https_health_check['check_interval_sec']" -%> }
+  its('unhealthy_threshold') { should eq <%= doc_generation ? "'#{https_health_check['unhealthy_threshold']}'" : "https_health_check['unhealthy_threshold']" -%> }
+end
+
+describe google_compute_https_health_check(project: <%= doc_generation ? "#{gcp_project_id}" : "gcp_project_id" -%>, name: 'nonexistent') do
+  it { should_not exist }
+end

templates/inspec/examples/google_compute_https_health_checks.erb

@@ -0,0 +1,7 @@
+<% gcp_project_id = "#{external_attribute('gcp_project_id', doc_generation)}" -%>
+<% https_health_check = grab_attributes['https_health_check'] -%>
+describe google_compute_https_health_checks(project: <%= doc_generation ? "#{gcp_project_id}" : "gcp_project_id" -%>) do
+  its('names') { should include <%= doc_generation ? "'#{https_health_check['name']}'" : "https_health_check['name']" -%> }
+  its('timeout_secs') { should include <%= doc_generation ? "'#{https_health_check['timeout_sec']}'" : "https_health_check['timeout_sec']" -%> }
+  its('check_interval_secs') { should include <%= doc_generation ? "'#{https_health_check['check_interval_sec']}'" : "https_health_check['check_interval_sec']" -%> }
+end

templates/inspec/tests/integration/build/gcp-mm.tf

@@ -46,6 +46,10 @@ variable "http_health_check" {
   type = "map"
 }
 
+variable "https_health_check" {
+  type = "map"
+}
+
 resource "google_compute_ssl_policy" "custom-ssl-policy" {
   name            = "${var.ssl_policy["name"]}"
   min_tls_version = "${var.ssl_policy["min_tls_version"]}"
@@ -173,4 +177,14 @@ resource "google_compute_http_health_check" "gcp-inspec-http-health-check" {
 
   timeout_sec        = "${var.http_health_check["timeout_sec"]}"
   check_interval_sec = "${var.http_health_check["check_interval_sec"]}"
+}
+
+resource "google_compute_https_health_check" "gcp-inspec-https-health-check" {
+  project      = "${var.gcp_project_id}"
+  name         = "${var.https_health_check["name"]}"
+  request_path = "${var.https_health_check["request_path"]}"
+
+  timeout_sec         = "${var.https_health_check["timeout_sec"]}"
+  check_interval_sec  = "${var.https_health_check["check_interval_sec"]}"
+  unhealthy_threshold = "${var.https_health_check["unhealthy_threshold"]}"
 }

templates/inspec/tests/integration/configuration/mm-attributes.yml

@@ -66,4 +66,11 @@ http_health_check:
   name: inspec-gcp-http-health-check
   request_path: /health_check
   timeout_sec: 20
-  check_interval_sec: 20
+  check_interval_sec: 20
+
+https_health_check:
+  name: inspec-gcp-https-health-check
+  request_path: /https_health_check
+  timeout_sec: 15
+  check_interval_sec: 15
+  unhealthy_threshold: 3