Empty reservations must ignore empty (#3541)

GoogleCloudPlatform · May 20, 2020 · 9c4f020 · 9c4f020
1 parent 47e1d5e
commit 9c4f020
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 23 deletions.
diff --git a/templates/terraform/examples/bigquery_reservation_basic.tf.erb b/templates/terraform/examples/bigquery_reservation_basic.tf.erb
@@ -5,5 +5,5 @@ resource "google_bigquery_reservation" "<%= ctx[:primary_resource_id] %>" {
 	// Set to 0 for testing purposes
 	// In reality this would be larger than zero
 	slot_capacity  = 0
-	ignore_idle_slots = true
+	ignore_idle_slots = false
 }
diff --git a/third_party/terraform/tests/resource_bigquery_reservation_test.go.erb b/third_party/terraform/tests/resource_bigquery_reservation_test.go.erb
@@ -11,7 +11,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/terraform"
 )
 
-func TestAccBigqueryReservationReservation_bigqueryReservationUpdate(t *testing.T) {
+func TestAccBigqueryReservationReservation_bigqueryReservation(t *testing.T) {
 	t.Parallel()
 
 	location := "asia-northeast1"
@@ -33,33 +33,12 @@ func TestAccBigqueryReservationReservation_bigqueryReservationUpdate(t *testing.
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
-			{
-				Config: testAccBigqueryReservationReservation_bigqueryReservationUpdate(context),
-			},
-			{
-				ResourceName:      "google_bigquery_reservation.reservation",
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
 		},
 	})
 }
 
 func testAccBigqueryReservationReservation_bigqueryReservationBasic(context map[string]interface{}) string {
 	return Nprintf(`
-resource "google_bigquery_reservation" "reservation" {
-	name           = "reservation%{random_suffix}"
-	location       = "%{location}"
-	// Set to 0 for testing purposes
-	// In reality this would be larger than zero
-	slot_capacity  = 0
-	ignore_idle_slots = true
-}
-`, context)
-}
-
-func testAccBigqueryReservationReservation_bigqueryReservationUpdate(context map[string]interface{}) string {
-	return Nprintf(`
 resource "google_bigquery_reservation" "reservation" {
 	name           = "reservation%{random_suffix}"
 	location       = "%{location}"