Skip to content

Commit

Permalink
Default output to true for Fingerprint (#11833)
Browse files Browse the repository at this point in the history
  • Loading branch information
zli82016 authored Sep 26, 2024
1 parent 9702300 commit 7a17be1
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions mmv1/api/type.go
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ func (t *Type) SetDefault(r *Resource) {
if t.Description == "" {
t.Description = fmt.Sprintf("A reference to %s resource", t.Resource)
}
case t.IsA("Fingerprint"):
// Represents a fingerprint. A fingerprint is an output-only
// field used for optimistic locking during updates.
// They are fetched from the GCP response.
t.Output = true
default:
}

Expand Down Expand Up @@ -647,17 +652,6 @@ func (t *Type) GetDescription() string {
return strings.TrimSpace(strings.TrimRight(t.Description, "\n"))
}

// TODO rewrite: validation
// Represents a fingerprint. A fingerprint is an output-only
// field used for optimistic locking during updates.
// They are fetched from the GCP response.
// class Fingerprint < FetchedExternal
// func (t *Type) validate
// super
// @output = true if @output.nil?
// end
// end

// TODO rewrite: validation
// class Array < Composite
// check :item_type, type: [::String, NestedObject, ResourceRef, Enum], required: true
Expand Down

0 comments on commit 7a17be1

Please sign in to comment.