Add interconnect attachment state waiting (#2999)

Merged PR #2999.

products/compute/api.yaml

@@ -6602,6 +6602,9 @@ objects:
         path: 'name'
         base_url: 'projects/{{project}}/regions/{{region}}/operations/{{op_id}}'
         wait_ms: 1000
+        timeouts: !ruby/object:Api::Timeouts
+          insert_minutes: 10
+          delete_minutes: 10
       result: !ruby/object:Api::OpAsync::Result
         path: 'targetLink'
       status: !ruby/object:Api::OpAsync::Status

products/compute/terraform.yaml

@@ -920,6 +920,14 @@ overrides: !ruby/object:Overrides::ResourceOverrides
   InstanceTemplate: !ruby/object:Overrides::Terraform::ResourceOverride
     exclude: true
   InterconnectAttachment: !ruby/object:Overrides::Terraform::ResourceOverride
+    examples:
+      - !ruby/object:Provider::Terraform::Examples
+        name: "interconnect_attachment_basic"
+        primary_resource_id: "on_prem"
+        skip_test: true
+        vars:
+          interconnect_attachment_name: "on-prem-attachment"
+          router_name: "router"
     properties:
       id: !ruby/object:Overrides::Terraform::PropertyOverride
         exclude: true
@@ -939,14 +947,10 @@ overrides: !ruby/object:Overrides::ResourceOverrides
         default_from_api: true
       vlanTag8021q: !ruby/object:Overrides::Terraform::PropertyOverride
         default_from_api: true
-    examples:
-      - !ruby/object:Provider::Terraform::Examples
-        name: "interconnect_attachment_basic"
-        primary_resource_id: "on_prem"
-        skip_test: true
-        vars:
-          interconnect_attachment_name: "on-prem-attachment"
-          router_name: "router"
+    custom_code: !ruby/object:Provider::Terraform::CustomCode
+      constants: templates/terraform/constants/interconnect_attachment.go.erb
+      post_create: templates/terraform/post_create/interconnect_attachment.go.erb
+      pre_delete: templates/terraform/pre_delete/interconnect_attachment.go.erb
   License: !ruby/object:Overrides::Terraform::ResourceOverride
     exclude: true
   MachineType: !ruby/object:Overrides::Terraform::ResourceOverride

templates/terraform/constants/interconnect_attachment.go.erb

@@ -0,0 +1,18 @@
+// waitForAttachmentToBeProvisioned waits for an attachment to leave the
+// "UNPROVISIONED" state, to indicate that it's either ready or awaiting partner
+// activity.
+func waitForAttachmentToBeProvisioned(d *schema.ResourceData, config *Config, timeout time.Duration) error {
+	return resource.Retry(timeout, func() *resource.RetryError {
+		if err := resourceComputeInterconnectAttachmentRead(d, config); err != nil {
+			return resource.NonRetryableError(err)
+		}
+
+		name := d.Get("name").(string)
+		state := d.Get("state").(string)
+		if state == "UNPROVISIONED" {
+			return resource.RetryableError(fmt.Errorf("InterconnectAttachment %q has state %q.", name, state))
+		}
+		log.Printf("InterconnectAttachment %q has state %q.", name, state)
+		return nil
+	})
+}

templates/terraform/post_create/interconnect_attachment.go.erb

@@ -0,0 +1,3 @@
+if err := waitForAttachmentToBeProvisioned(d, config, d.Timeout(schema.TimeoutCreate)); err != nil {
+  return fmt.Errorf("Error waiting for InterconnectAttachment %q to be provisioned: %q", d.Get("name").(string), err)
+}

templates/terraform/pre_delete/interconnect_attachment.go.erb

@@ -0,0 +1,3 @@
+if err := waitForAttachmentToBeProvisioned(d, config, d.Timeout(schema.TimeoutCreate)); err != nil {
+  return fmt.Errorf("Error waiting for InterconnectAttachment %q to be provisioned: %q", d.Get("name").(string), err)
+}