Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Adding documentation for HTTPS #143

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Adding documentation for HTTPS #143

merged 1 commit into from
Mar 7, 2018

Conversation

nikhiljindal
Copy link
Contributor

Adding documentation for HTTPS ingresses

cc @csbell @G-Harmon

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@nikhiljindal
Copy link
Contributor Author

Had pushed the commit with wrong author :)
Fixed it now

@nikhiljindal nikhiljindal mentioned this pull request Mar 7, 2018
Merged
G-Harmon
G-Harmon approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@G-Harmon G-Harmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. 2 minor comments.

examples/zone-printer/https.md Outdated
While a single cluster ingress also supports blocking HTTP traffic all together,
kubemci does not support it yet.

https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/142 has
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"#142 is the feature request for this" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

examples/zone-printer/https.md

In addition, updating the secret is not yet supported.

https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/issues/141 has
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"#141 has more details and includes a workaround" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@nikhiljindal
Copy link
Contributor Author

Thanks for the review @G-Harmon
Updated code as per comments.

Also updated ingress-gce documentation to ensure that it has instructions for both pre-shared cert annotation and secret: kubernetes/ingress-gce#144

@nikhiljindal
Copy link
Contributor Author

cc @prameshj as FYI

@G-Harmon G-Harmon merged commit c87873e into GoogleCloudPlatform:master Mar 7, 2018
@nikhiljindal nikhiljindal mentioned this pull request Apr 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@G-Harmon G-Harmon G-Harmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhiljindal @googlebot @G-Harmon