Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format validation for SecretManagerSecretRef and SecretManagerSecretVersionRef #3521

Conversation

jingyih
Copy link
Collaborator

@jingyih jingyih commented Jan 22, 2025

Fix error

{"severity":"error","timestamp":"2025-01-22T07:00:49.994Z","msg":"Reconciler error","controller":"dataformrepository-controller","controllerGroup":"dataform.cnrm.cloud.google.com","controllerKind":"DataformRepository","DataformRepository":{"name":"dataformrepository-2tmq7a3ku34xkma","namespace":"2tmq7a3ku34xkma"},"namespace":"2tmq7a3ku34xkma","name":"dataformrepository-2tmq7a3ku34xkma","reconcileID":"645ec9cc-8246-42bb-ad57-b3ded07f6cd1","error":"Update call failed: failed to resolve resource references format of secretManagerSecretVersionRef external=\"projects/518915279/secrets/secretmanagersecret-2tmq7a3ku34xkma/versions/1\" was not known (use projects/<projectId>/secrets/<secretID>/versions/<versionID>)"}

@jingyih
Copy link
Collaborator Author

jingyih commented Jan 22, 2025

/assign @acpana @yuwenma

@jingyih jingyih changed the title Fix secretmanagersecret validation fix format validation for SecretManagerSecretRef and SecretManagerSecretVersionRef Jan 22, 2025
@jingyih jingyih changed the title fix format validation for SecretManagerSecretRef and SecretManagerSecretVersionRef Fix format validation for SecretManagerSecretRef and SecretManagerSecretVersionRef Jan 22, 2025
@jingyih jingyih force-pushed the fix_secretmanagersecret_validation branch from e7fd45b to 1cd212c Compare January 22, 2025 07:22
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 22, 2025
@jingyih jingyih added this to the 1.128 milestone Jan 22, 2025
@yuwenma
Copy link
Collaborator

yuwenma commented Jan 27, 2025

/approve

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8b2f404 into GoogleCloudPlatform:master Jan 27, 2025
18 checks passed
jingyih added a commit that referenced this pull request Jan 29, 2025
jingyih added a commit that referenced this pull request Jan 29, 2025
google-oss-prow bot added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants