-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix format validation for SecretManagerSecretRef and SecretManagerSecretVersionRef #3521
Fix format validation for SecretManagerSecretRef and SecretManagerSecretVersionRef #3521
Conversation
…etManagerSecretVersionRef
e7fd45b
to
1cd212c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acpana Could you help moving the dataformrepository to use the new SecretManager reference https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/apis/secretmanager/v1beta1/secret_reference.go
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b2f404
into
GoogleCloudPlatform:master
Fix error