mockgcp: apigeeorganization #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpana
commented
Jan 21, 2025
| enabled: false | ||
| monetizationConfig: | ||
| enabled: false | ||
| # addonsConfig: |
There was a problem hiding this comment.
Setting addons seems to be nondeterministic (my experience) for this DCL resource. I'd say we convert it to direct then we won't have an issue stemming from the underlying DCL. Till then I commented these out.
There was a problem hiding this comment.
Awesome, thank you @acpana !
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/mockorg
branch
from
c812755 to
bbfc9e2
Compare
|
/assign @jasonvigil |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
google-oss-prow
bot
merged commit 67c56b8
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly rips #2297 so I can use it in
ApigeeEnvironments so I can use it inApigeeEnvgroupAttachments