chore: replace slugify dependency #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
force-pushed
the
replace_slugify
branch
3 times, most recently
from
f86b007 to
db2ea75
Compare
yuwenma
reviewed
Jan 21, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justinsb
force-pushed
the
replace_slugify
branch
from
db2ea75 to
5ddca1e
Compare
One of the dependabots was failing to create a PR to update it, so I bumped the version (using gemini), and then looked at whether we should be using it at all |
We should own this behaviour, so we can guarantee compatability.
justinsb
force-pushed
the
replace_slugify
branch
from
5ddca1e to
2df1001
Compare
|
/lgtm |
google-oss-prow
bot
merged commit f86cf73
into
GoogleCloudPlatform:master
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should own this behaviour, so we can guarantee compatability.