Adding mocks for cloudidentity membership API #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
reviewed
Jan 14, 2025
| @@ -25,3 +33,16 @@ func ValueOf[T any](p *T) T { | |||
| } | |||
| return v | |||
| } | |||
|
|
|||
| func buildLRO(obj proto.Message) (*longrunning.Operation, error) { | |||
There was a problem hiding this comment.
Nit: we do have an operations helper - search for operations.StartLRO
barney-s
changed the title
barney-s
force-pushed
the
cidentmgr-mock-a
branch
from
5b9d168 to
9038f77
Compare
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
barney-s
force-pushed
the
cidentmgr-mock-a
branch
4 times, most recently
from
f4dd163 to
2bed312
Compare
generated using: hack/compare-mock fixtures/addexpirydatecloudidentitymembership hack/compare-mock fixtures/addrolecloudidentitymembership hack/compare-mock fixtures/removerolecloudidentitymembership
…ents tests from failing
Commands run: WRITE_GOLDEN_OUTPUT=1 ./scripts/github-actions/tests-e2e-scenarios.sh hack/compare-mock fixtures/fullcsaugkehubfeaturemembership hack/compare-mock fixtures/fullpocogkehubfeaturemembership hack/compare-mock fixtures/fullacmgkehubfeaturemembership hack/compare-mock fixtures/basicacmgkehubfeaturemembership hack/compare-mock fixtures/basicpocogkehubfeaturemembership hack/compare-mock fixtures/basiccsaugkehubfeaturemembership hack/compare-mock fixtures/acmfeature hack/compare-mock fixtures/mcifeature hack/compare-mock fixtures/gkehubmembership hack/compare-mock fixtures/meshgkehubfeaturemembership
barney-s
force-pushed
the
cidentmgr-mock-a
branch
from
2bed312 to
df0ea5d
Compare
WRITE_GOLDEN_OUTPUT=1 ./scripts/github-actions/tests-e2e-fixtures
|
/lgtm |
google-oss-prow
bot
merged commit d3cf43e
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Adding mocks for cloudidentity membership API
Tests Run
The following tests passed:
E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock go test -test.count=1 -timeout 3600s -v ./tests/e2e -run TestAllInSeries/fixtures/addexpirydatecloudidentitymembership 2>&1 | tee log.cloudidentity
E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock go test -test.count=1 -timeout 3600s -v ./tests/e2e -run TestAllInSeries/fixtures/addrolecloudidentitymembership 2>&1 | tee log.cloudidentity
E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock go test -test.count=1 -timeout 3600s -v ./tests/e2e -run TestAllInSeries/fixtures/removerolecloudidentitymembership 2>&1 | tee log.cloudidentity