Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the external reference for MemoryStoreInstance #3436

Merged

Conversation

anhdle-sso
Copy link
Collaborator

@anhdle-sso anhdle-sso commented Dec 19, 2024

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@anhdle-sso anhdle-sso requested a review from yuwenma December 19, 2024 22:39
@yuwenma
Copy link
Collaborator

yuwenma commented Dec 20, 2024

/lgtm
/approve

Thanks! The SQL seems to be a flake. Just kicked off a rerun.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2c1d999 into GoogleCloudPlatform:master Dec 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants