Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto generated mapper #3312

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

auto generated mapper #3312

wants to merge 13 commits into from

Conversation

himanikh
Copy link
Contributor

@himanikh himanikh commented Dec 4, 2024

Change description

Fixes #

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maqiuyujoyce for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anhdle-sso
anhdle-sso reviewed Jan 16, 2025
View reviewed changes
pkg/controller/direct/memorystore/instance_controller.go
// TODO(contributor): Complete the gcp "CREATE" or "INSERT" request.
req := &memorystorepb.CreateInstanceRequest{
Instance: resource,
InstanceId: a.id.ID(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you don't need to provide id during creat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/pkg/controller/direct/redis/cluster/rediscluster_controller.go#L219

I followed the pattern here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himanikh How the Memorystore service handle the request if InstanceID is given or not given?

If the given instanceID points to an already exist instance object, will the service returns error (409 or 400) or ignore?
If the Id is not given, will it get the ID from the other instance field?

pkg/controller/direct/memorystore/instance_controller.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhdle-sso anhdle-sso anhdle-sso left review comments

@yuwenma yuwenma yuwenma left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@anhdle-sso anhdle-sso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himanikh @yuwenma @anhdle-sso