feat: Direct controller for compute target TCP proxy(regional) #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmahou
force-pushed
the
direct-controller-tcp-regional
branch
3 times, most recently
from
e458c3e to
1a587fa
Compare
1 task
gemmahou
force-pushed
the
direct-controller-tcp-regional
branch
8 times, most recently
from
149e141 to
700a42b
Compare
gemmahou
force-pushed
the
direct-controller-tcp-regional
branch
from
fb752f6 to
10294a8
Compare
|
All the diffs in commit are related to healthcheck or backend service, not from tcp proxy |
yuwenma
reviewed
Nov 20, 2024
| actual *computepb.TargetTcpProxy | ||
| reader client.Reader | ||
| id *krm.ComputeTargetTCPProxyRef | ||
| targetTcpProxiesClient *gcp.TargetTcpProxiesClient |
There was a problem hiding this comment.
nit: globalGCPClient regionalGCPClient
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit de797cd
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
based on #3047
Tests you have done
make ready-prto ensure this PR is ready for review.