Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encryption to AlloyDB secondary cluster sample #1450

Conversation

199201shubhamsahu
Copy link
Member

Fixes #1445

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@199201shubhamsahu
Copy link
Member Author

/assign justinsb

@justinsb
Copy link
Collaborator

Thank you @199201shubhamsahu

/approve
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 27, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bca5d32 into GoogleCloudPlatform:master Mar 27, 2024
7 of 8 checks passed
@199201shubhamsahu 199201shubhamsahu deleted the alloydb-sample-sec-cluster branch April 22, 2024 03:07
@yuwenma yuwenma added this to the 1.117 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AlloyDB Cluster sample test-failure
3 participants