WIP: genapi TagsTagValue #1435
Open
WIP: genapi TagsTagValue #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
justinsb
commented
Mar 26, 2024
justinsb
commented
- Move computed fields to status.observedState for newly added resources
- Ensure reconciliation works after computed fields are moved to status.observedState
- Run make ready-pr
- Ensure sever-generated ID is parsed correctly in tftokrm
- Update allowlist and address comments
- ci: add dcl upgrade probe
- use go-vcr package
- use go-vcr package
- add hook
- remove debugInfo
- remove debugInfo
- custom matcher
- ci: update pull request template
- chore: Update Contributing doc
- Return nil when observedState is not found in status
- print the actual error when parsing resourceID panics
- mockgcp: Implement TagsTagValue
- tests: run deletion in order when we're doing golden testing
- genapi: create direct IAM ServiceAccount controller
- Spike: ComputeNetwork controller
- Move to proto
- genapi: direct controller for ComputeSubnetwork
- genapi: Add support for TagsTagKey
- genapi: TagsTagValue
This does mean that we have to have the objects pre-ordered correctly, but it means that (deletion) requests will be made in a consistent order.
This API is not the most complicated, but it is also unusual in that the resource identifier (primary key) is variable.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.