Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockgcp: Fix return type for mockapikeys #1202

Closed

Conversation

justinsb
Copy link
Collaborator

@justinsb justinsb commented Feb 6, 2024

I believe two PRs "crossed in the mail", and thus the interface method
has the wrong return type.

I believe two PRs "crossed in the mail", and thus the interface method
has the wrong return type.
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemmahou
Copy link
Collaborator

gemmahou commented Feb 6, 2024

Duplicate of #1194

@gemmahou gemmahou marked this as a duplicate of #1194 Feb 6, 2024
@justinsb
Copy link
Collaborator Author

justinsb commented Feb 6, 2024

Looks like this was fixed in #1194 (thanks!)

/close

@google-oss-prow google-oss-prow bot closed this Feb 6, 2024
Copy link
Contributor

@justinsb: Closed this PR.

In response to this:

Looks like this was fixed in #1194 (thanks!)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maqiuyujoyce
Copy link
Collaborator

Just curious - why was the issue not detected by the presubmit test in #1168 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants