slack-support

[adriantr]

Adding slack support

[jpassing]

Thanks again for creating this PR.

Not sure if this is ready for review yet, but I added some preliminary comments.

[adriantr]

@jpassing thanks for taking a look. Wasn't yet ready, no, but should be tomorrow after some live testing! I think I adressed all your points in the new approach 🙌

[jpassing]

Isn't this pulled in automatically as a transitive dependency?

[adriantr]

Was assuming that too, but wasn't the case. Ended up crashing with every notification

[jpassing]

I wonder if we even need the slack-api-client and okhttp dependency -- it seems like all that needs to happen here is something like:

    var payload = (...)
    HttpTransport.newTransport()
        .createRequestFactory()
        .buildPostRequest(
            new GenericUrl("https://slack..."),
            new JsonHttpContent(new GsonFactory(), payload))
        .execute();

We don't have to do this in this PR -- but I'm always looking for ways to reduce the number of dependencies, so I might want to do it as a follow-up task.

[adriantr]

sounds reasonable, what's needed for now it's basically this:

POST https://hooks.slack.com/services/T00000000/B00000000/XXXXXXXXXXXXXXXXXXXXXXXX
Content-type: application/json
{
    "text": "Hello, world."
}

[jpassing]

Depending on the type of notification, the message should be different. Could we use the same template mechamism as in the SMTP adapter?

[adriantr]

will fix, it's not HTML though, so might have to do it a bit differently.

[michalbagrowski]

Is this feature operational, can it be tested?

[adriantr]

@michalbagrowski the ambition is to refactor it throughout june due to lack of time recently. I am however running it in our production env currently, so feel free to fork my repo.

[rajat2911]

Hello @adriantr What environment variables we need to use here to have slack notifications

[rh-sph]

@adriantr we are trying to integrate JIT with Slack for approval, any update when this will be available?

[jpassing]

Note that you can also configure JIT Access to post notifications to a Pub/Sub topic. You could listen to those notifications and relay them to Slack or other systems.