feat(compute): add compute disk create secondary custom sample #9644
+132
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: compute
TetyanaYahodska
added
the
kokoro:run
TetyanaYahodska
requested review from
yoshi-approver and
a team
as code owners
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
Sita04
requested changes
Dec 27, 2024
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.TimeoutException; | ||
|
|
||
| public class CreateDiskSecondaryCustom { |
There was a problem hiding this comment.
Considering refactoring the class name to CreateSecondaryCustomDisk.
There was a problem hiding this comment.
Thank you! Renamed
| String primaryDiskSource = String.format("projects/%s/zones/%s/disks/%s", | ||
| primaryProjectId, primaryDiskZone, primaryDiskName); | ||
|
|
||
| DiskAsyncReplication asyncReplication = DiskAsyncReplication.newBuilder() |
There was a problem hiding this comment.
Please move all compute API related code within the try catch. Applies to all samples across PRs.
| .get(3, TimeUnit.MINUTES); | ||
|
|
||
| if (response.hasError()) { | ||
| return null; |
There was a problem hiding this comment.
Print and then throw an error.
There was a problem hiding this comment.
Thank you! Fixed
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
Sita04
approved these changes
Dec 28, 2024
| } | ||
| return disksClient.get(secondaryProjectId, secondaryDiskZone, secondaryDiskName); | ||
| return response.getStatus(); |
There was a problem hiding this comment.
Return the operation response.
There was a problem hiding this comment.
Returned Operation.Status as was done for other samples
kokoro-team
removed
the
kokoro:run
TetyanaYahodska
added
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation - https://cloud.google.com/compute/docs/disks/async-pd/configure?authuser=0#gcloud_1
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only