-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMS: fixes the kms failing tests. #817
Conversation
Fix the tests introduced in GoogleCloudPlatform#816. Some code was still calling encrypt(...) with a key version.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
weird, commits from my personal machine weren't picked up by Google CLA. Should be fixed now. |
CLAs look good, thanks! |
Thanks. |
Well, it didn't quite make it. Something I should do?
|
Following up. It looks like there is no Right now it looks like the test project has N key versions, and the primary is set to 1. I'll update these tests so each test does a "rotate", aka a create + set-primary. |
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…form-v1beta1 to v0.13.2 (#817) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1](https://togithub.com/googleapis/java-) | `0.13.1` -> `0.13.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.13.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.13.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.13.2/compatibility-slim/0.13.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.13.2/confidence-slim/0.13.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
### Migrating samples from [googleapis/java-aiplatform](https://togithub.com/googleapis/java-aiplatform/tree/main/samples) into [java-docs-samples/aiplatform](https://togithub.com/GoogleCloudPlatform/java-docs-samples) --- - feat: initial code generation - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#2) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.19 (#11) - samples: update pom.xml (s) in the samples dir (#24) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#14) - test(deps): update dependency junit:junit to v4.13.1 - test(deps): update dependency com.google.truth:truth to v1.1 (#33) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.2 (#38) - samples: ucaip samples batch 3 of 6 (#18) - samples: ucaip batch samples 4 of 6 (#19) - samples: ucaip batch samples 5 of 6 (#20) - samples: ucaip samples batch 6 of 6 (#17) - samples: ucaip sample batch 2 of 6 (#15) - chore: delete ununsed format script (#48) - samples: initial commit and it is missing env vars for testing (#7) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.1.0 (#59) - samples(deps): update dependency com.google.cloud:google-cloud-storage to v1.113.3 (#55) - samples(deps): update dependency com.google.protobuf:protobuf-java-util to v4.0.0-rc-2 (#27) - samples: adds custom model, action recognition samples and tests (#111) - feat: adds ValueConverter utility and demo samples (#108) - samples(deps): update dependency com.google.cloud:google-cloud-storage to v1.113.8 (#72) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.2.0 (#133) - test(deps): update dependency com.google.truth:truth to v1.1.2 (#138) - samples: adds enhanced library samples (#134) - test(deps): update dependency junit:junit to v4.13.2 (#161) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.9 (#132) - fix: reduces image object detection test resource file size (#154) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.10 (#164) - feat: updates library for v1 service (#157) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.11 (#175) - docs: updates prediction to new hostname (#173) - chore: replaced hard-coded values with env vars (#185) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.12 (#186) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.3.0 (#188) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.3.0 (#189) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.14 (#202) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v0.4.0 (#209) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#223) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.4.0 (#210) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.15 (#232) - samples: updates samples to v1 (1 of 8) (#206) - samples: updates samples to v1 (2 of 8) (#212) - test(teardown): refactored teardown section of test (#254) - test(env var): added missing requireEnv val (#255) - samples: updates samples to v1 (3 of 8) (#215) - samples: updates samples to v1 (5 of 10) (#235) - samples: updates samples to v1 (4 of 10) (#233) - deps: update dependency com.google.cloud:google-cloud-storage to v1.113.16 (#334) - chore: Increasing timeout createdataset (#337) - samples: updates samples to v1 (7 of 10) (#238) - samples: updates samples to v1 (6 of 10) (#236) - samples: updates samples to v1 (8 of 8) (#239) - deps: update dependency com.google.cloud:google-cloud-storage to v1.114.0 (#349) - deps: update dependency com.google.code.gson:gson to v2.8.7 (#382) - test(deps): update dependency com.google.truth:truth to v1.1.3 (#383) - chore: changes product name to 'Vertex AI' (#373) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#399) - deps: update dependency com.google.cloud:google-cloud-storage to v1.115.0 (#396) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v1 (#406) - chore: disabling ITs to reduce cost & resolve quota issue (#421) - deps: update dependency com.google.cloud:google-cloud-storage to v1.117.1 (#422) - test: Refactor teardown (#424) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.5.1 (#428) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v1.0.2 (#427) - deps: update dependency com.google.cloud:google-cloud-storage to v1.118.0 (#440) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.5.2 (#434) - deps: update dependency com.google.cloud:google-cloud-storage to v2 (#610) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2 (#609) - deps: update dependency com.google.cloud:google-cloud-storage to v2.0.1 (#612) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.6.0 (#608) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.0.1 (#616) - deps: update dependency com.google.code.gson:gson to v2.8.8 (#622) - deps: update dependency com.google.cloud:google-cloud-storage to v2.0.2 (#621) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.6.1 (#617) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.0 (#630) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.6.2 (#629) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.0.2 (#628) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.1.0 (#640) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.1 (#644) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.0 (#650) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.0 (#641) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.1 (#660) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.2 (#662) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.1 (#661) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.2 (#666) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.3 (#667) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.4 (#669) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.5 (#673) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.2 (#665) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.3 (#678) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.3 (#677) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.2.4 (#681) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.6 (#683) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.8.4 (#682) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.7 (#689) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.8 (#696) - deps: update dependency com.google.cloud:google-cloud-storage to v2.1.9 (#698) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.3.0 (#702) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.9.0 (#703) - deps: update dependency com.google.code.gson:gson to v2.8.9 (#707) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.0 (#710) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.1 (#722) - docs: Added evalId comment to samples (#727) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.10.0 (#733) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.4.0 (#732) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.11.0 (#740) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.5.0 (#739) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.2 (#747) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.11.2 (#744) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.5.2 (#748) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.24 (#734) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#749) - test: Add null check in teardown (#752) - deps: update dependency com.google.cloud:google-cloud-storage to v2.2.3 (#764) - deps: update dependency com.google.cloud:google-cloud-storage to v2.3.0 (#773) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.11.3 (#762) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.5.3 (#761) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.6.0 (#784) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.12.0 (#782) - deps: update dependency com.google.code.gson:gson to v2.9.0 (#792) - deps: update dependency com.google.cloud:google-cloud-storage to v2.4.0 (#783) - deps: update dependency com.google.cloud:google-cloud-storage to v2.4.4 (#801) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.0 (#807) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.0 (#808) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.1 (#813) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.1 (#812) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.2 (#819) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.2 (#817) - deps: update dependency com.google.cloud:google-cloud-storage to v2.4.5 (#818) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.3 (#822) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.3 (#823) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.7.4 (#828) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.13.4 (#829) - deps: update dependency com.google.cloud:google-cloud-storage to v2.5.0 (#834) - deps: update dependency com.google.cloud:google-cloud-storage to v2.5.1 (#835) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.0 (#838) - deps: update dependency com.google.cloud:google-cloud-storage to v2.6.0 (#840) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.0 (#839) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.1 (#846) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.1 (#847) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.2 (#852) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.2 (#851) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.3 (#855) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.3 (#856) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.4 (#860) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.4 (#859) - deps: update dependency com.google.cloud:google-cloud-storage to v2.6.1 (#863) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.5 (#868) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.5 (#869) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.6 (#875) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.6 (#874) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.7 (#878) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.7 (#879) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.8 (#882) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.8 (#883) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.14.9 (#890) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.8.9 (#889) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.0 (#915) - deps: update dependency com.google.cloud:google-cloud-storage to v2.7.0 (#916) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.0 (#914) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.1 (#919) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.1 (#920) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.2 (#924) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.2 (#923) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.3 (#927) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.3 (#928) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.4 (#932) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.4 (#931) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.5 (#936) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.5 (#935) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.6 (#941) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.6 (#942) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v2.9.7 (#953) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.7 (#954) - feat(samples): add create-featurestore sample (#948) - feat(samples): added all entity type samples (#976) - feat(samples): add remaining featurestore api samples (#974) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3 (#986) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.17.0 (#1003) - deps: update dependency com.google.code.gson:gson to v2.9.1 (#1001) - deps: update dependency com.google.cloud:google-cloud-storage to v2.10.0 (#1004) - feat(samples): add all feature samples (#980) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.0 (#1005) - feat(samples): add all feature values samples (#981) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 (#1006) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.1 (#1008) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.2 (#1010) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 (#1009) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.2.0 (#1020) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 (#1021) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 (#1016) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 (#1026) - deps: update dependency com.google.cloud:google-cloud-storage to v2.11.3 (#1015) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 (#1031) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 (#1040) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 (#1044) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.19.0 (#1051) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.3.0 (#1050) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 (#1046) - deps: update dependency com.google.cloud:google-cloud-storage to v2.12.0 (#1047) - feat(sample): featurestore node updates (#1028) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.4.0 (#1085) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.17.0 (#1082) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.20.0 (#1086) - deps: update dependency com.google.cloud:google-cloud-storage to v2.13.0 (#1087) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.17.1 (#1092) - chore(deps): update dependency com.google.cloud:google-cloud-aiplatform to v3.4.1 (#1090) - deps: update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.20.1 (#1091) - deps: update dependency com.google.cloud:google-cloud-bigquery to v2.18.0 (#1113) Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] Please **merge** this PR for me once it is approved.
Fix the tests introduced in #816.
Some code was still calling encrypt(...) with a key version.