Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: talent solution v4 samples tests #2977

Merged
merged 7 commits into from
May 28, 2020
Merged

fix: talent solution v4 samples tests #2977

merged 7 commits into from
May 28, 2020

Conversation

munkhuushmgl
Copy link
Contributor

Fixes #2970

Looks like job posting by default was expired and deleted in 30 days.
That's why this happens once in a month.

I found out that I can customize the expiration date in job posting, and created one job for testing that expires in 40 years from now.

@munkhuushmgl munkhuushmgl requested a review from a team May 27, 2020 03:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but I really think using protobuf.Timestamp is a very bad idea and should be discouraged.

@munkhuushmgl
Copy link
Contributor Author

@lesv Looks like I do not have a write permission to merge this

@lesv lesv merged commit 86cea4d into master May 28, 2020
@lesv lesv deleted the talent-sln-v4-bugs branch May 28, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HistogramSearchJobsTest: testHistogramSearch failed
4 participants