Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data Catalog samples to client library V1 #2604

Conversation

mesmacosta
Copy link
Contributor

With release of V1 library, we must update the samples to instruct users to use the supported version.

  • [ x] Tests pass
  • [ n/a] Appropriate changes to README are included in PR
  • [ n/a] API's need to be enabled to test (tell us)
  • [ n/a] Environment Variables need to be set (ask us to set them)

@mesmacosta mesmacosta requested a review from a team April 8, 2020 21:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2020
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Apr 8, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@mesmacosta
Copy link
Contributor Author

@lesv can you add kokoru:run label?

@kurtisvg kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 9, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 9, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2020
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit ce2a721 into GoogleCloudPlatform:master Apr 9, 2020
charlieyu1996 pushed a commit that referenced this pull request Nov 11, 2022
With release of V1 library, we must update the samples to instruct users to use the supported version.

- [ x] Tests pass
- [ n/a] Appropriate changes to README are included in PR
- [ n/a] API's need to be enabled to test (tell us)
- [ n/a] Environment Variables need to be set (ask us to set them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants