Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cli functionality to dataproc quickstart #2047

Merged
merged 7 commits into from
Feb 3, 2020
Merged

Conversation

bradmiro
Copy link
Contributor

I made the Dataproc quickstart runnable and provided instructions on how to run it with maven.

@bradmiro bradmiro requested review from kurtisvg and a team January 30, 2020 16:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We strongly prefer not to have CLI components for Java samples. The reason for this is that the vast majority of users use an IDE, and copy and paste the snippets from the doc site. They should be able to run the sample in their IDE, as they may not be comfortable with the command-line.

If you absolutely have to have interaction via command-line, you can reformat the existing no-args quickstart to a Main function and include instructions to edit the snippet to run the main class. This allows it to be run from the command-line while still preserving the ability for the function to be triggered in an IDE easily.

@kurtisvg kurtisvg assigned kurtisvg and unassigned gguuss Jan 30, 2020
@bradmiro
Copy link
Contributor Author

Given that this is an E2E tutorial, I discussed with the TW and we agreed that all of the "quickstart" samples in all languages should be runnable as-is without modifying any code (including uncommenting and setting variables). This is the only sample we intend to do this for and the rest will follow the traditional framework, such as the createCluster sample. I definitely acknowledge we're making atypical trade-offs to create this functionality.

@bradmiro bradmiro requested a review from kurtisvg February 3, 2020 21:49
@bradmiro bradmiro merged commit 6dd3dba into master Feb 3, 2020
@bradmiro bradmiro deleted the dataproc-samples branch February 3, 2020 22:24
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
* Changed quickstart to be an executable program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants