Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude generated code files from code coverage. #198

Closed
wants to merge 1 commit into from
Closed

Exclude generated code files from code coverage. #198

wants to merge 1 commit into from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 26, 2016

This was causing the Coveralls plugin to fail with "Source not found".

@tswast
Exclude generated code files from code coverage.
8e5923e 
This was causing the Coveralls plugin to fail with "Source not found".
@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

@lesv One more change to coverage plugin.

I was able to manually run the plugin. Hopefully this means we'll get a coverage report after Travis finishes.

mvn clean cobertura:cobertura coveralls:report -DrepoToken=OUR-TOKEN

I'm thinking we should reconsider how we handle protocol buffers, since this will be a pain to maintain, and I'm afraid we might exclude more than we mean to.

@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

Ugh. Coveralls had another error when running on Travis.

[ERROR] Failed to execute goal org.eluder.coveralls:coveralls-maven-plugin:4.1.0:report (default-cli) on project doc-samples: Build error: Line number 52 is greater than the source file appengine/datastore/src/main/java/com/example/appengine/Greeting.java size -> [Help 1]

I'll look into this.

@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

"My guess is that you have multi-module project containing duplicate package/class names"
trautonen/coveralls-maven-plugin#73 (comment)

We probably do this. I think I use the com.example.appengine in multiple modules. I'll see about pulling some of them into unique names.

@tswast
Copy link
Contributor Author

tswast commented Apr 26, 2016

I'll close this for now. Hopefully codecov works better. #199

@tswast tswast closed this Apr 26, 2016
@lesv lesv deleted the coveralls branch April 26, 2016 23:18
minherz pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 0.120.1 (#191)
2da5007 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10)


### Bug Fixes

* **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
@release-please @minherz
chore: release 0.120.1 (#191)
47806c1 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10)


### Bug Fixes

* **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
@release-please @minherz
chore: release 0.120.1 (#191)
977e774 
🤖 I have created a release \*beep\* \*boop\* 
---
### [0.120.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.120.0...v0.120.1) (2020-08-10)


### Bug Fixes

* **v1beta1:** migrate to grpc_service_config ([#195](https://www.github.com/googleapis/java-errorreporting/issues/195)) ([3a2ddcf](https://www.github.com/googleapis/java-errorreporting/commit/3a2ddcfb8da2f376be800c62b32f96b271d9f1d2))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#189](https://www.github.com/googleapis/java-errorreporting/issues/189)) ([fb6dbc7](https://www.github.com/googleapis/java-errorreporting/commit/fb6dbc7633397761772d812fa9f55923ea0ca006))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#193](https://www.github.com/googleapis/java-errorreporting/issues/193)) ([cdbb26b](https://www.github.com/googleapis/java-errorreporting/commit/cdbb26b95b4e9d90d664c91210512c70d112acde))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#198](https://www.github.com/googleapis/java-errorreporting/issues/198)) ([0d29ee2](https://www.github.com/googleapis/java-errorreporting/commit/0d29ee2023c45a49a08d0c8b08e1571137500cd1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
charlieyu1996 pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v7.0…
6898dec 
….1 (#198)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | patch | `7.0.0` -> `7.0.1` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-talent).
This was referenced Nov 10, 2022
Closed
Merged
bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v5.5…
05b1c80 
….0 (#198)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `5.4.0` -> `5.5.0` |

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-dataproc).
@bourgeoisor bourgeoisor mentioned this pull request Nov 11, 2022
Merged
9 tasks
Sita04 pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-security…
23a28ef 
…-private-ca to v1 (#198)
@Sita04 Sita04 mentioned this pull request Nov 11, 2022
Merged
9 tasks
Sita04 pushed a commit that referenced this pull request Jan 17, 2023
@renovate-bot @Sita04
chore(deps): update dependency com.google.cloud:google-cloud-security…
49657f4 
…-private-ca to v1 (#198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tswast