fix: small updates to dataproc sample, test and pom #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d femoved endpoint configuring in CreateClusterTest.java
… slight mod to pom
googlebot
added
the
cla: yes
|
@bradmiro Can you rebase this to the current version of master? |
kurtisvg
reviewed
Nov 15, 2019
| @@ -75,8 +76,13 @@ public void createClusterTest() throws IOException, InterruptedException { | |||
|
|
|||
| @After | |||
| public void tearDown() throws IOException, InterruptedException { | |||
| String myEndpoint = String.format("%s-dataproc.googleapis.com:443", REGION); | |||
There was a problem hiding this comment.
Is there a way to file an issue on the client library for this?
The region is already passed in the deleteClusterAsyncRequest, and it seems unncessary to force the user to create a new regional client just to delete a cluster.
There was a problem hiding this comment.
I agree and this is consistent across all of the languages. I have this documented on my end.
kurtisvg
approved these changes
Nov 16, 2019
bourgeoisor
pushed a commit
that referenced
this pull request
Nov 11, 2022
* refactored and added tags to infinite speech streaming sample (#1605) * Changed 'main' region tag * Removed extra lines around tags and changed client import to v1 * Create dataproc directory and add CreateCluster sample * reverting changes to speech infinite streaming sample * Added java versions to pom * Several changes to file formatting as per request in the PR * Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java * Fixed version for parent config * Added clarity to futures requests by expanding variables * Fixed linting errors * Fixed import ordering * Moved exceptions to function level in dataproc create cluster sample + test * Re-added endpoint to test, changed region tags to include 'dataproc', slight mod to pom * fix to pom
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight change to pom, changed region tags to include 'dataproc', added endpoint back to test (would not successfully delete the cluster without this)