Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added command line option class + option to pass different lang code as argument #1504

Merged
merged 17 commits into from
Jul 22, 2019
Merged

Added command line option class + option to pass different lang code as argument #1504

merged 17 commits into from
Jul 22, 2019

Conversation

munkhuushmgl
Copy link
Contributor

No description provided.

@munkhuushmgl munkhuushmgl requested a review from a team July 8, 2019 20:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 8, 2019
beccasaurus
beccasaurus approved these changes Jul 8, 2019
View reviewed changes
Copy link

@beccasaurus beccasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a feature standpoint, very very useful for testing this streaming sample.

I can't speak on behalf of the Java though :)

lesv
lesv reviewed Jul 9, 2019
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurtisvg I'm inclined to approve, even though we are trying to avoid CLI's for java. This seems like a reasonable exception.

speech/cloud-client/README.md Show resolved Hide resolved
@munkhuushmgl
Copy link
Contributor Author

@lesv I will change it to English

@munkhuushmgl munkhuushmgl requested a review from lesv July 9, 2019 18:07
@kurtisvg
Copy link
Contributor

kurtisvg commented Jul 9, 2019

@kurtisvg I'm inclined to approve, even though we are trying to avoid CLI's for java. This seems like a reasonable exception.

lesv@ - This appears to have an existing CLI, so small updates to existing sample fall within our current policy.

That said, this change is contrary to the samples best practices. While using a function variable is more useful when running from the command-line, it's less useful when used as a snippet because now there is a variable that is declared out of scope.

To follow the sample guidelines it should be left as "en-US" or similar valid value, and should include a link to where a list of valid values can be found.

@munkhuushmgl
Copy link
Contributor Author

@kurtisvg I will revert back the code, and will include a link to list of valid values[language codes] inside README

@beccasaurus
Copy link

Clarification for everyone –

This isn't actually a snippet. This is a CLI sample application used for tutorials and demos.

In the coming months, we hope to send a PR which will refactor this code so that it has region tags to support a website tutorial which is being authored based on this application.

This isn't a snippet, it's a CLI application :)

@beccasaurus
Copy link

@munkhuushmgl Based on your testing out this application, I'm +1 having this flag for choosing language. It's one of the very first things you found yourself wanting to do, so it'll be important for a good chunk of our users, we shouldn't hard-code this to English. I recommend that we also update the Python and Node.js applications to support the same flag (in the future)

Note: it's not important to me that this PR goes in now, we could also wait to submit a PR with a fully refactored sample ready to be used in a detailed tutorial.

@munkhuushmgl munkhuushmgl requested a review from beccasaurus July 12, 2019 20:16
@munkhuushmgl munkhuushmgl requested a review from beccasaurus July 19, 2019 18:10
@munkhuushmgl munkhuushmgl dismissed beccasaurus’s stale review July 22, 2019 21:07

all requested changes have been resolved

@munkhuushmgl munkhuushmgl merged commit c0210e2 into master Jul 22, 2019
@lesv lesv deleted the adding-cmd-options-langs branch July 22, 2019 23:22
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl @chingor13
samples: Added command line option class + option to pass different l…
c3e846c 
…ang code as argument (#1504)

* added different language option for other than english

* changed it to english

* timestamp change

* changed millisecond format to min:sec

* Revert "timestamp change"

This reverts commit df21c30.

* removed indent issues

* made requested changes
@Shabirmean Shabirmean mentioned this pull request Nov 17, 2022
Merged
9 tasks
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 17, 2022
@Shabirmean
samples: migrate code from googleapis/java-speech (#7437)
6161d0f 
### Migrating samples from [googleapis/java-speech](https://togithub.com/googleapis/java-speech/tree/main/samples) into [java-docs-samples/speech](https://togithub.com/GoogleCloudPlatform/java-docs-samples)
---

- samples: Speech GA - library update (#1212)
- samples: Due to API backend changes, update the samples to match (#1595)
-  fix: update retry configs, adds generated samples (#26)
- build: move clirr to separate check (#30)
- feat: add speaker_tag to WordInfo (#40)
- chore: update common templates, regenerate tests
- samples: Fix flaky speech test for speaker diarization (#1829)
- chore(regen): update license year for generated files (#82)
- chore(regen): regenerate with updated year
- samples: move generated samples to generated directory (#105)
- chore: update common templates
- samples: fix: flaky tests in speech (#2286)
- samples: speech: move samples out of branch (#2324)
- samples: scaffold pom.xml files (#118)
- chore(deps): update dependency com.google.cloud:libraries-bom to v4.3.0 (#122)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.13 (#126)
- samples: update shared config (#2443)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#130)
- chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.0 (#131)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#133)
- chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.1 (#134)
- chore(deps): update dependency com.google.cloud:libraries-bom to v5 (#144)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.16 (#149)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.17 (#153)
- chore: fix samples snippets and update name in repo-metadata (#155)
- chore(deps): update dependency com.google.cloud:libraries-bom to v5.2.0 (#160)
- chore(deps): update dependency com.google.cloud:libraries-bom to v5.3.0 (#167)
- chore(deps): update dependency com.google.cloud:libraries-bom to v5.5.0 (#177)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#200)
- chore(deps): update dependency com.google.cloud:libraries-bom to v5.7.0 (#199)
- chore(deps): update dependency com.google.cloud:libraries-bom to v6 (#210)
- chore(deps): update dependency com.google.cloud:libraries-bom to v7 (#214)
- chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.1 (#222)
- chore(deps): update dependency com.google.cloud:libraries-bom to v8 (#227)
- chore(deps): update dependency com.google.cloud:libraries-bom to v8.1.0 (#237)
- samples: Add Speech API quickstart sample. (#497)
- samples: Adds sync / async examples for local and remote files
- samples: Fixes whitespace around while blocks
- samples: Adds some basic javadocs and comments
- samples: Infer project from env
- samples: Updates to use v1 release.
- samples: Fixes checkstyle issues.
- samples: Adds streaming example and tests.
- samples: Nits found in self-review.
- samples: Removes commented out code snippet and adds note on async local file limit.
- samples: Speech async examples (#612)
- samples: Vision speech upgrade (#641)
- samples: updating to latest google-cloud-* dependencies (#723)
- samples: Upgrades client and addresses changes to long running operations
- samples: Adds support for word time offset
- samples: Minimizes cloud maven dependencies and fixes lint warnings
- samples: Fixes seconds reported in word time offsets and enables maven checks
- samples: Updates to highlight word time offsets (#787)
- samples: Use only first alternative. Comments for clarity (#837)
- samples: Auto-update dependencies. (#853)
- samples: Auto-update dependencies. (#912)
- samples: Updated mlengine, monitoring, pubsub, spanner, and speech. (#993)
- samples: Speech samples (#1036)
- samples: Add model selection to streaming sample (#1073)
- samples: Model selection (#1074)
- samples: Add Auto-Punctuation samples to speech (#1079)
- samples: Add samples for enhanced models and metadata (#1093)
- samples: Add speech beta samples (#1151)
- samples: [DO_NOT_MERGE] Microphone streaming with a 1 minute duration. (#1185)
- samples: Speech region tag update (#1188)
- samples: updates word time offsets region tag (#1191)
- samples: Speech GA - library update (#1212)
- samples: Bump QuickStartSample to v1 (#1285)
- samples: Infinite Stream recognition (#1297)
- samples: Speech multi-channel GA (#1341)
- samples: Data logging opt-in is no longer required for enhanced models (#1360)
- samples: Updated Infinite streaming sample (#1422)
- samples: Revert Tests, product team rolled back changes, Auto Punctuation behavior is back to the expected output (#1428)
- samples: Increase timeout to 5 mins (#1453)
- samples: Update Recognize.java (#1460)
- samples: Add back missing break statement (#1512)
- samples: Added command line option class + option to pass different lang code as argument (#1504)
- samples: Update a default value to parameter (#1522)
- samples: Add samples for speech diarization ga (auto-punctuation samples alrea… (#1744)
- samples: speech: add ga samples and fix some flaky tests (#2049)
- samples: update shared config (#2443)
- samples: speech: make flaky tests generic (#2825)
- samples: fix test dependencies
- chore(deps): update dependency com.google.cloud:libraries-bom to v9 (#263)
- chore(deps): update dependency com.google.cloud:libraries-bom to v10 (#271)
- chore(deps): update dependency com.google.cloud:libraries-bom to v11
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#294)
- chore(deps): update dependency com.google.cloud:libraries-bom to v12 (#298)
- test(deps): update dependency junit:junit to v4.13.1
- chore(deps): update dependency com.google.cloud:libraries-bom to v12.1.0 (#310)
- chore(deps): update dependency com.google.cloud:libraries-bom to v13 (#321)
- chore(deps): update dependency com.google.cloud:libraries-bom to v13.1.0 (#326)
- test(deps): update dependency com.google.truth:truth to v1.1 (#322)
- chore(deps): update dependency com.google.cloud:libraries-bom to v13.2.0 (#332)
- chore(deps): update dependency com.google.cloud:libraries-bom to v13.3.0 (#334)
- chore(deps): update dependency com.google.cloud:libraries-bom to v13.4.0 (#338)
- chore(deps): update dependency com.google.cloud:libraries-bom to v14 (#347)
- chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#350)
- chore(deps): update dependency com.google.cloud:libraries-bom to v15.1.0 (#357)
- chore(deps): update dependency com.google.cloud:libraries-bom to v16 (#364)
- samples: add recognize sample with profanity filter (#376)
- samples: refactor quickstart to use a gcs file (#378)
- chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.0 (#389)
- samples: add multi region transcribe sample (#394)
- chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.1 (#398)
- chore(deps): update dependency com.google.cloud:libraries-bom to v16.3.0 (#405)
- test(deps): update dependency com.google.truth:truth to v1.1.2 (#407)
- chore(deps): update dependency com.google.cloud:libraries-bom to v16.4.0 (#423)
- test(deps): update dependency junit:junit to v4.13.2 (#428)
- chore(deps): update dependency com.google.cloud:libraries-bom to v17 (#441)
- chore(deps): update dependency com.google.cloud:libraries-bom to v18 (#445)
- chore(deps): update dependency com.google.cloud:libraries-bom to v18.1.0 (#456)
- chore(deps): update dependency com.google.cloud:libraries-bom to v19 (#459)
- chore(samples): adds model adaptation sample (#468)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#482)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20 (#486)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.1.0 (#493)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.2.0 (#505)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.3.0 (#514)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.4.0 (#523)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.5.0 (#535)
- test(deps): update dependency com.google.truth:truth to v1.1.3 (#537)
- chore: change region (#538)
- samples: adds export to GCS sample (#544)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.6.0 (#552)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#551)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.7.0 (#568)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.8.0 (#578)
- chore(deps): update dependency com.google.cloud:libraries-bom to v20.9.0 (#589)
- chore(deps): update dependency com.google.cloud:libraries-bom to v21 (#625)
- chore(deps): update dependency com.google.cloud:libraries-bom to v22 (#650)
- chore(deps): update dependency com.google.cloud:libraries-bom to v23 (#663)
- chore: migrate to owlbot (#660)
- chore(deps): update dependency com.google.cloud:libraries-bom to v23.1.0 (#702)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24 (#719)
- deps: update dependency commons-cli:commons-cli to v1.5.0 (#720)
- sample: Configure polling algorithm in long recognition sample (#464)
- chore: cleanup cloud RAD generation (#1269) (#725)
- docs(samples): refactors the export-to-gcs sample (#737)
- deps: update dependency org.json:json to v20211205 (#745)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.24 (#742)
- chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#753)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.0 (#758)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.1 (#759)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.2 (#764)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24.2.0 (#775)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24.3.0 (#794)
- chore(deps): update dependency com.google.cloud:libraries-bom to v24.4.0 (#823)
- deps: update dependency org.json:json to v20220320 (#835)
- chore(deps): update dependency com.google.cloud:libraries-bom to v25 (#834)
- chore(deps): update dependency com.google.cloud:libraries-bom to v25.1.0 (#849)
- chore(deps): update dependency com.google.cloud:libraries-bom to v25.2.0 (#876)
- chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 (#883)
- chore(deps): update dependency com.google.cloud:libraries-bom to v25.4.0 (#892)
- chore(deps): update dependency com.google.cloud:libraries-bom to v26 (#918)
- chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.0 (#938)
- chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.1 (#941)
- chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.2 (#957)
- deps: update dependency org.json:json to v20220924 (#961)
- chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.3 (#975)

Fixes #issue

> It's a good idea to open an issue first for discussion.

- [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md)
- [ ] `pom.xml` parent set to latest `shared-configuration`
- [ ] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
- [ ] **Tests** pass:   `mvn clean verify` **required**
- [ ] **Lint**  passes: `mvn -P lint checkstyle:check` **required**
- [ ] **Static Analysis**:  `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only**
- [ ] Please **merge** this PR for me once it is approved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@beccasaurus beccasaurus Awaiting requested review from beccasaurus

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@munkhuushmgl @kurtisvg @beccasaurus @lesv @googlebot