Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Spanner: Specify the name for packaging the JAR #1430

Merged
merged 2 commits into from
May 21, 2019
Merged

Cloud Spanner: Specify the name for packaging the JAR #1430

merged 2 commits into from
May 21, 2019

Conversation

hegemonic
Copy link
Contributor

Right now, the Cloud Spanner docs go stale whenever we upgrade the parent to a new version. The docs are stale right now, in fact; they say 1.0.10, but the current version is 1.0.11 (example).

With this change, we can update the docs to tell customers to run something like mvn package -Drevision=0.1.0-SNAPSHOT, and then use 0.1.0-SNAPSHOT throughout the examples.

Right now, the Cloud Spanner docs go stale whenever we upgrade the parent to a new version. The docs are stale right now, in fact; they say `1.0.10`, but the current version is `1.0.11` (example: [1]).

With this change, we can update the docs to tell customers to run something like `mvn package -Drevision=0.1.0-SNAPSHOT`, and then use `0.1.0-SNAPSHOT` throughout the examples.

[1]: https://cloud.google.com/spanner/docs/getting-started/java/
@hegemonic hegemonic requested a review from a team May 21, 2019 19:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 from me on this. This change isn't idiomatic for java, and might teach someone who doesn't know better a bad practice.

A better solution would be package the jar with a specific name, as mentioned here.

The new sample guidelines strong discourage using CLIs for samples, so perhaps this is a good time to consider removing them.

@hegemonic
Copy link
Contributor Author

FWIW, Cloud Spanner provides a very similar "getting started" doc for every language we support (.NET example), and there's a CLI for every language. It would be nice to maintain parity across languages, so I'm not eager to rip out the CLI code.

I'm more than happy, though, to package the JAR in a more idiomatic way! PTAL.

@hegemonic hegemonic changed the title Cloud Spanner: Allow version overrides on the command line Cloud Spanner: Specify the name for packaging the JAR May 21, 2019
@kurtisvg kurtisvg merged commit 76be7a7 into GoogleCloudPlatform:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants